Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: make createStyle go to original definition #3108

Merged
merged 2 commits into from Dec 10, 2022
Merged

types: make createStyle go to original definition #3108

merged 2 commits into from Dec 10, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Dec 4, 2022

By making this change, a user can click on the className to go to the original definition. Like clicking on classes.wrapper, it'll go to the object where wrapper was defined. Also renaming wrapper will rename it from all the places

@rtivital
Copy link
Member

rtivital commented Dec 4, 2022

@imranbarbhuiya please fix failing tests

@imranbarbhuiya
Copy link
Contributor Author

I wasn't at home so did it from phone 😂 I'll fix the formatting once I open my laptop.

@rtivital
Copy link
Member

rtivital commented Dec 4, 2022

@imranbarbhuiya please fix failing tests

@imranbarbhuiya
Copy link
Contributor Author

imranbarbhuiya commented Dec 4, 2022

Hi, I think my ide was merging this prettier config with my user level default one. I formatted it from cli now can u run the workflow again, please?

@rtivital
Copy link
Member

rtivital commented Dec 5, 2022

It does not work, example with Accordion.Panel component after and before your changes
Снимок экрана 2022-12-05 в 20 17 26
Снимок экрана 2022-12-05 в 20 17 48

@imranbarbhuiya
Copy link
Contributor Author

It might be due to the last change I did which I didn't tested. I'll test everything and will inform you.

@imranbarbhuiya
Copy link
Contributor Author

imranbarbhuiya commented Dec 5, 2022

The extends was causing the issue. Now to fix it, I had to use the generic and an assertion too. But if u don't like the assertion, lmk I'll try if it's possible to make it work with a simpler solution without breaking existing typings

@rtivital rtivital merged commit ecb4b15 into mantinedev:master Dec 10, 2022
@rtivital
Copy link
Member

It works now, thanks!

@imranbarbhuiya imranbarbhuiya deleted the types/createStyle branch December 10, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants