Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.8.4 and beyond lead to our Drawer contents not being displayed #3468

Closed
Nantris opened this issue Feb 2, 2023 · 4 comments
Closed

5.8.4 and beyond lead to our Drawer contents not being displayed #3468

Nantris opened this issue Feb 2, 2023 · 4 comments

Comments

@Nantris
Copy link
Contributor

Nantris commented Feb 2, 2023

What package has an issue

@mantine/core

Describe the bug

5.8.0 and 5.8.3 works great, but everything above that we get an empty white drawer.

It works in the docs, but it no longer works for us.

I traced Mantine as the source by manually bisecting versions.

The fix for #3056 appears to be an undocumented breaking change

I'm not sure how the change breaks it though: fd08c2f

This appears to be because it breaks restyling the component with Emotion by defining an exclusive className on the component.

const StyledDrawer = styled(Drawer)`
  contain: strict;
  animation: ${animations.fadeIn} 500ms;
`;

What version of @mantine/hooks page do you have in package.json?

5.8.4

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

None

Are you willing to participate in fixing this issue and create a pull request with the fix

None

Possible fix

No response

@rtivital
Copy link
Member

rtivital commented Feb 2, 2023

Please check if 6.0.0-alpha.2 resolves your issue with Drawer

@Nantris
Copy link
Contributor Author

Nantris commented Feb 2, 2023

Unfortunately the Drawer fails to open with both alpha.2 and alpha.3. No error appears in the console. I'm not sure if maybe this is due to an API change or if it's a bug.

In 5.x.x, apparently, using the Drawer component instead of styled(Drawer) yields the same problems, so it's not an issue with styled.

It appears to be caused by using CSS contain (with any option besides "none") inside of the Drawer. I don't understand how the changes caused that though. Perhaps it was a different commit in 5.8.4

@Nantris
Copy link
Contributor Author

Nantris commented Feb 2, 2023

Apparently this is fixed by applying height: 100% to .mantine-Drawer-body.

@rtivital
Copy link
Member

rtivital commented Feb 3, 2023

Please provide a sandbox then, I do not understand the issue – Drawer works correctly on mantine.dev website

@Nantris Nantris closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants