-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@mantine/core] fix slider drag and hover behavior #4000
[@mantine/core] fix slider drag and hover behavior #4000
Conversation
@jvdsande focus styles are incorrect, focus ring should appear only when user navigates with keyboard. In storybook it appears when slider is dragged. It works correctly only after mark was clicked (not sure why). 2023-04-06.13.43.51.mov |
Hm, I missed that while testing. I'll look into it today! |
f495622
to
e488323
Compare
@rtivital I've found the issue and fixed it |
Thanks! |
@jvdsande after this PR, slider does not respect container width, can you send a PR with a fix? You can compare it with v5:
|
I'll look into it tonight, but as far as I know it was already like that in other V6, I'll see what I can do |
I've reverted this PR commit in a separate branch and the issue is gone – https://github.com/mantinedev/mantine/tree/revert-8bee2e5 I've already migrated slider in v7 and faced the same issue. I wasn't able to make mark clicks work the same way as they work now while keeping click behavior, so not really sure if that is possible. I've just disabled pointer-events on marks to remove confusing behavior. |
I actually remember adding a weird negative margin to fix this the other way around. I think it might have fixed it in storybook specifically and broke it everywhere else. When I'm home I'll find the proper way to fix this in all situation |
Fix some Slider behavior: