[@mantine/core] fix portal props typings and override order #4009
+22
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of
portalProps
requireschildren
to be specified, when we don't want or need them here. There is also an override order that is wrong ifwithinPortal
is passed both toportalProps
and the component props itself.For TypeScript users:
children
is now removed from the prop types everywherewithinPortal
is removed from the prop types when it exists on the component type (which is always the case for now I think)target
is removed from the prop types if it's overwritten inside the component implementationFor JavaScript users:
withinPortal
andtarget
passed throughportalProps
do not override internaltarget
and component-levelwithinPortal
anymore