You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
and as ModalRootProps does not have sx prop in it, <Modal /> does not accept sx prop anymore
my exact usecase is sx={{ maxHeight: '90vh' }}
if it was an intended breaking change, then it should be added to CHANGELOG. And please let me know if there is another proper way to handle my use case.
What version of @mantine/hooks page do you have in package.json?
6.0.7
If possible, please include a link to a codesandbox with the reproduced problem
No response
Do you know how to fix the issue
Yes
Are you willing to participate in fixing this issue and create a pull request with the fix
Yes
Possible fix
add sx prop to ModalRootProps
The text was updated successfully, but these errors were encountered:
What package has an issue
@mantine/core
Describe the bug
<Modal />
component does not supportsx
prop after a change toModalProps
type in this commit:a013d98
export interface ModalProps extends Omit<DefaultProps<ModalStylesNames, ModalStylesParams>, MantineStyleSystemSize>, Omit<React.ComponentPropsWithoutRef<'div'>, 'title'>
changed to
export interface ModalProps extends ModalRootProps
and as ModalRootProps does not have
sx
prop in it,<Modal />
does not acceptsx
prop anymoremy exact usecase is
sx={{ maxHeight: '90vh' }}
if it was an intended breaking change, then it should be added to CHANGELOG. And please let me know if there is another proper way to handle my use case.
What version of @mantine/hooks page do you have in package.json?
6.0.7
If possible, please include a link to a codesandbox with the reproduced problem
No response
Do you know how to fix the issue
Yes
Are you willing to participate in fixing this issue and create a pull request with the fix
Yes
Possible fix
add
sx
prop toModalRootProps
The text was updated successfully, but these errors were encountered: