[@mantine/core] fix multi-select hovered item on last item select #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
agong-coveo
pushed a commit
to agong-coveo/mantine
that referenced
this pull request
May 3, 2023
…isableSelectedItemFiltering` is set and last item is selected (mantinedev#4168) Co-authored-by: jvandersande <jeremie.van-der-sande@ubisoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
disableSelectedItemFilteringis set to true, selecting the last item will move the focus to the second-to-last instead of keeping it on the last.This is due to a workaround for selected-item detection needed in normal mode.
This PR changes the workaround: instead of handling it as an edge-case in
handleItemSelect, I converted it into a rule in the render:hoveredshould never be greater than the last item's index.This way if the item number does not change on select, the hovered value is not impacted.