[@mantine/core] AppShell: Fix wrong padding when navbarOffsetBreakpoint and asideOffsetBreakpoint have the same value
#4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neokidev
changed the title
neokidev
force-pushed
the
issue-4269-appshell-prototype
branch
from
b2e240d
to
847b658
Compare
neokidev
changed the title
navbarOffsetBreakpoint and asideOffsetBreakpoint have the same value
|
I created this PR without a link to the issue. It would be appreciated if you could provide a link to #4269 . |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
navbarOffsetBreakpointandasideOffsetBreakpointvalues in theAppShellcomponent are set to the same value, only the aside padding is correctly overridden withpadding-right: 1rem.Therefore, I have made adjustments to ensure that
padding-left: 1rem;is correctly applied as well. With this change, both the aside and navbar will have the intended padding.Fixes #4269