[@mantine/core] Table: Avoid style bleed #4393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure table stylings apply to immediate children only
|
Thanks! |
|
I think this PR started causing an issue #4433 |
|
@apoco Can you fix this? Otherwise, the PR will be reverted in the next patch. |
|
I found the bug. Will send a fix 😮💨 |
|
In case it'd be faster, basically this selector on line 77: ...should have been: |
|
Pull request to fix this in #4443; sorry about that, and thanks again for a great library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure table stylings apply to immediate children only. This avoids things like the calendar pop-up nested inside of a
<Table/>inheriting the styles of the parent.