Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rightSection prop for PasswordInput have no effect #4436

Closed
eriolo opened this issue Jun 21, 2023 · 3 comments
Closed

rightSection prop for PasswordInput have no effect #4436

eriolo opened this issue Jun 21, 2023 · 3 comments

Comments

@eriolo
Copy link

eriolo commented Jun 21, 2023

What package has an issue

@mantine/core

Describe the bug

Hi,

I noticed that the rightSection for the PasswordInput doesn't render, e.g. I cannot see the "Right section" in the DOM.

<PasswordInput
  label="Password"
  placeholder="Set a password"
  rightSection={<div>Right section</div>}
/>

What version of @mantine/hooks page do you have in package.json?

^6.0.13

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/green-leftpad-yztjkq

Do you know how to fix the issue

None

Are you willing to participate in fixing this issue and create a pull request with the fix

None

Possible fix

No response

@rtivital
Copy link
Member

PasswordInput rightSection is occupied by password visibility toggle control. If you need right section, use <TextInput type="password" /> instead.

@mrbnclt
Copy link
Contributor

mrbnclt commented Jun 21, 2023

The docs might have caused this confusion as the props rightSection is included in the PasswordInput component props page.

It might be better to remove the rightSection props in the docs as it is not really used by PasswordInput component.

rtivital added a commit that referenced this issue Jul 18, 2023
@rtivital
Copy link
Member

Fixed in 6.0.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants