[@mantine/hooks] useResizeObserver: convert to mutable ref and fix useEffect #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
|
Thanks! |
puehringer
added a commit
to datavisyn/visyn_core
that referenced
this pull request
Aug 12, 2023
Now that @mantine/core contains the [fix](https://github.com/mantinedev/mantine/releases/tag/6.0.19) for incorrect [useResizeObserver typings](mantinedev/mantine#4632), we can safely upgrade again.
arel
pushed a commit
to arel/mantine
that referenced
this pull request
Sep 13, 2023
…izeObserver` in the previous patch (mantinedev#4632) * revert changes to the hook * use useIsomorphicEffect hook instead of useEffect * initialize rect with getBoundingClientRect * fix prettier issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts most of the changes in #4512 because it introduced a breaking change to the useResizeObserver hook. Instead of using callback ref, the hook will keep using mutable ref. But I replaced
useEffectwithuseIsomorphicEffectso that the size is calculated as soon as element is mounted.