Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@mantine/dropzone keyboard activation not working #6095

Closed
1 of 2 tasks
joshua-webdev opened this issue Apr 16, 2024 · 1 comment
Closed
1 of 2 tasks

@mantine/dropzone keyboard activation not working #6095

joshua-webdev opened this issue Apr 16, 2024 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@joshua-webdev
Copy link
Contributor

joshua-webdev commented Apr 16, 2024

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.7.0

What package has an issue?

@mantine/dropzone

What framework do you use?

Vite

In which browsers you can reproduce the issue?

Chrome

Describe the bug

I can't seem to activate the file picker by focusing on the dropzone component and pressing either space or enter. V6 works, so I believe the issue relates to some interaction with react-dropzone-esm which was introduced in V7. More specifically, rootRef seems to be null, so we never make it past this condition.

If possible, include a link to a codesandbox with a minimal reproduction

No response

Possible fix

If you remove ref from ...getRootProps({ ref }), on this line, then the keyboard activation works, but I'm not sure if that's the best solution? I think also ...getRootProps is creating a prop called ref which if you try to access it, even just looking at it via dev tools, you get the special props warning.

Self-service

  • I would be willing to implement a fix for this issue
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Apr 23, 2024
@rtivital
Copy link
Member

Fixed in 7.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants