Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "fetch latest" #279

Open
okainov opened this issue Aug 16, 2018 · 5 comments
Open

Implement "fetch latest" #279

okainov opened this issue Aug 16, 2018 · 5 comments

Comments

@okainov
Copy link
Contributor

okainov commented Aug 16, 2018

Looks like currently "Fetch latest" does the full fetch... It would be nice to fetch latest 100 or something like this instead

public function import_latest( $p_repo ) {
        return $this->import_full( $p_repo );
@dregad
Copy link
Member

dregad commented Aug 21, 2018

This is not specific to Gitlab. For most (if not all) plugins, import_latest is actually the same as import_full indeed.

Contributions welcome.

@dregad dregad changed the title [Gitlab] Implement "fetch latest" Implement "fetch latest" Aug 21, 2018
@okainov
Copy link
Contributor Author

okainov commented Aug 21, 2018

In this case maybe it makes more sense to hide this button if plugin doesn't support it? Or raise an error "not implemented".
Because in other case it causes confusion, especially in combination with different translation strings, they give user impression that some different action will be performed.

@dregad
Copy link
Member

dregad commented Aug 22, 2018

maybe it makes more sense to hide this button if plugin doesn't support it

I'm fine with that approach.

@seanm
Copy link

seanm commented Jun 23, 2021

My svn post-commit script was broken for a little while, and so I'm in the situation where some kind of "fetch latest" would be nice... but is it at least harmless to press? Will it result in my latest commits being linked (good) but all old commits getting double linked (bad)?

@seanm
Copy link

seanm commented Jun 27, 2021

OK, to answer my own question, it seems to do the correct/expected thing, yay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants