Broken module, broken tests

[ferlores]

Hi @mantoni
I just realized that if you delete your node_module folder and npm install the dependencies again mochify doesn't report back the result of the tests run in phantom. It looks like a dependency got broken.

I discover this through one of the projects where I use mochify, and I confirmed it by cloning the repo from scratch, npm install and run the tests. Half of them fail.

Do you mind looking at it?

Thanks!
F

[mantoni]

Thanks for the heads up. Will look into it as soon as I get near a computer.

-Max

Am 06.04.2015 um 23:13 schrieb Fernando Lores notifications@github.com:

Hi @mantoni
I just realized that if you delete your node_module folder and npm install the dependencies again mochify doesn't report back the result of the tests run in phantom. It looks like a dependency got broken.

I discover this through one of the projects where I use mochify, and I confirming by cloning the repo from scratch, npm install and run the tests. Half of them fail.

Do you mind looking at it?

Thanks!
F

—
Reply to this email directly or view it on GitHub.

[tjunghans]

I noticed the same issue. I don't see any test results. The only output is #phantomjs:. I'm using phantomjs v1.9.7 and mochify v2.7.0.

[mantoni]

This was introduce in browserify 9.0.5. As a quick fix, I'll nail browserify to 9.0.4.

Apparently, streams that are pushed to pipeling.get('wrap') are not part of the output stream anymore. E.g. inserting n.stdout.pipe(process.stdout); at this line shows the expected output on the console.

If anybody can look further into this, I'd be very thankful.

[mantoni]

Worked around in Mochify v2.7.1. Please re-install. I'll keep this issue open until there is a proper solution.

[mantoni]

I still don't understand the issue 100%, but v2.7.2 has a "good enough" workaround.