Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated nativeWindowOpen option from webPreferences in help module #152

Closed
manusa opened this issue Oct 9, 2022 · 1 comment · Fixed by #154
Closed

Remove deprecated nativeWindowOpen option from webPreferences in help module #152

manusa opened this issue Oct 9, 2022 · 1 comment · Fixed by #154
Assignees
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest
Milestone

Comments

@manusa
Copy link
Owner

manusa commented Oct 9, 2022

Description

The help BrowserView Electron webPreferences.nativeWindowOpen option should be removed since it has been deprecated and removed from the API.

The following code:

const webPreferences = {
contextIsolation: false,
nativeWindowOpen: true,
nodeIntegration: false,
sandbox: true,
preload: path.resolve(__dirname, '..', '..', 'bundles', 'help.preload.js')
};

Should be replaced by:

const webPreferences = {
  contextIsolation: false,
  nodeIntegration: false,
  sandbox: true,
  preload: path.resolve(__dirname, '..', '..', 'bundles', 'help.preload.js')
};
@manusa manusa added good first issue Good for newcomers hacktoberfest Hacktoberfest labels Oct 9, 2022
@chinmaym07
Copy link
Contributor

Hey @manusa Can I do this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants