Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mapbox/mapbox-gl-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.7.1
Choose a base ref
...
head repository: mapbox/mapbox-gl-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.8.0
Choose a head ref

Commits on Jan 19, 2022

  1. Fix variable anchors on globe (#11395)

    * Fix reprojection of symbols with variable anchors on globe
    * Enable variable anchor render tests on globe
    mpulkki-mapbox authored Jan 19, 2022
    Copy the full SHA
    bc98165 View commit details
  2. Copy the full SHA
    74559af View commit details
  3. Thin out repeated line labels at overscaled tiles (#11414)

    * Thin out repeated line labels at overscaled tiles
    
    Prior to this change, the repeated line labels (such as street names) were placed too densely on overscaled tiles, sometimes even closer than the value of the `symbol-spacing` property.
    This caused a noticeable increase in memory usage, and the memory use increased dramatically with higher tiles overscale factors.
    
    This change partially mitigates the issue with the following changes:
    * for "very" overscaled tiles (overscale factor > 2) on high zoom levels (z > 18) we use the tile pixel ratio from the previous zoom level
    * the distance between too repeated line labels is never smaller than the `symbol-spacing` style property value (tile pixel ratio is clamped to 1)
    
    * [tests] Update text-pitch-alignment/viewport-overzoomed-single-glyph test results
    pozdnyakov authored Jan 19, 2022
    Copy the full SHA
    203d674 View commit details
  4. Type matrix and vector calculations (#11400)

    * add Flow types for gl-matrix
    
    * update vec/matrix type references to proper types
    
    * fix more type references
    
    * type more vec3/quat functions
    
    * various vec/mat typing fixes
    
    * fix remaining matrix types
    
    * bump flow by 5 versions (last version that does not make new errors)
    
    * fix up flow after merge
    
    * revert globe matrix to double precision
    
    * revert globe tile matrix to double precision
    
    * address feedback
    mourner authored Jan 19, 2022
    Copy the full SHA
    1a038ed View commit details

Commits on Jan 20, 2022

  1. Copy the full SHA
    5f6b946 View commit details

Commits on Jan 21, 2022

  1. Copy the full SHA
    223ce9c View commit details
  2. Globe View: Prevent drawing symbols on the non-visible side of the gl…

    …obe (#11399)
    
    * Add globe sphere symbol occlusion
    
    * Add text render tests
    
    * Add more points
    
    * Add icon-allow-overlap render test
    
    * Add globe airports example
    
    * Move some computations to the CPU
    
    * Post rebase fixes (fixup flow)
    
    * Fix linter
    
    * Remove extraneous example
    
    * avoid temp array allocation in globe symbol uniforms
    
    * CPU side occlusion
    
    Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com>
    karimnaaji and mourner authored Jan 21, 2022
    Copy the full SHA
    4a1bef4 View commit details
  3. Copy the full SHA
    dbf0429 View commit details

Commits on Jan 24, 2022

  1. Upgrade Flow to v0.130 (#11431)

    * upgrade flow to v0.109, WIP fix errors in ui
    
    * more nullish type fixes
    
    * upgrade to flow v0.118, more fixes, deduplication
    
    * fixup
    
    * upgrade flow to v0.130.0
    
    * small cleanup
    mourner authored Jan 24, 2022
    Copy the full SHA
    3cde96f View commit details
  2. Copy the full SHA
    b0d9152 View commit details

Commits on Jan 25, 2022

  1. Fix e.isSourceLoaded to check if specific source is loaded (#11393)

    * e.isSourceLoaded uses map.isSourceLoaded instead of this.loaded
    
    * add back in space
    
    * Moved isSourceLoaded logic to style.js to reduce redundancy
    
    * moved this.style check to map.js
    
    * added e.isSourceLoaded check to map.isSourceLoaded unit test
    
    * added unit tests for e.isSourceLoaded
    
    * added back in isStyleLoaded test case
    
    * removed unneeded blank space
    
    * some cleaning up
    
    * fix typo in unit test
    
    * add unit-test with setData
    
    * condensed unit test
    
    * removed unneeded import statements
    
    * reduced redudancy of unit tests, added separate test for setData
    avpeery authored Jan 25, 2022
    Copy the full SHA
    83bde34 View commit details
  2. Upgrade Flow to v0.131.0 (#11436)

    * upgrade to Flow v0.131
    
    * fixup
    mourner authored Jan 25, 2022
    Copy the full SHA
    2ee823d View commit details
  3. Copy the full SHA
    f6eb04c View commit details

Commits on Jan 28, 2022

  1. Globe view: add circle layer support (#11437)

    * Add circle layer support to globe view
    
    * Enable circle layer render tests for the globe view
    
    * Clear tiles if projection has been switched from/to globe
    
    * Update render tests
    
    * Review fixes
    mpulkki-mapbox authored Jan 28, 2022
    Copy the full SHA
    d09ca9c View commit details
  2. Add an empty CodeBuild config to keep the build green (#11446)

    * create an noop CodeBuild config so that it's green for now
    
    * try non-empty phases
    mourner authored Jan 28, 2022
    Copy the full SHA
    5f24dec View commit details

Commits on Jan 31, 2022

  1. Copy the full SHA
    e42a2ec View commit details
  2. Copy the full SHA
    0489b61 View commit details

Commits on Feb 1, 2022

  1. Copy the full SHA
    a3e0368 View commit details

Commits on Feb 2, 2022

  1. Copy the full SHA
    ae201f6 View commit details
  2. Upgrade Flow to v0.142.0 (#11456)

    * WIP fix any-value flow types
    
    * fix remaining flow errors
    
    * upgrade Flow to v0.134.0
    
    * upgrade Flow to v0.136.0
    
    * upgrade Flow to v0.142.0
    mourner authored Feb 2, 2022
    Copy the full SHA
    b67b666 View commit details
  3. Always wrap center coordinate to the range [-180, 180] (#11448)

    * Wrap center after drag gesture
    
    * Add unit tests for globe.pointCoordinate
    
    * Add unit tests for shortestAngle
    
    Co-authored-by: Karim Naaji <karim.naaji@gmail.com>
    mpulkki-mapbox and karimnaaji authored Feb 2, 2022
    Copy the full SHA
    8083265 View commit details

Commits on Feb 3, 2022

  1. Copy the full SHA
    2ede838 View commit details
  2. Copy the full SHA
    bfeb8f9 View commit details
  3. Copy the full SHA
    6ffc4c0 View commit details

Commits on Feb 4, 2022

  1. Copy the full SHA
    7400f93 View commit details
  2. Copy the full SHA
    3c3fe28 View commit details
  3. [Flow] Type exports for data/* (#11472)

    * type exports for data/bucket/*
    
    * fix pos_attributes types
    
    * add export types for the rest of data/*
    
    * name return value type for LineVertexRange
    mourner authored Feb 4, 2022
    Copy the full SHA
    8dde786 View commit details
  4. Copy the full SHA
    69a888c View commit details
  5. Copy the full SHA
    3664a2d View commit details
  6. Remove unused code in terrain.js and fix lint config (#11473)

    * remove unused code in terrain.js and fix lint config
    
    * Remove extraneous param
    
    Co-authored-by: Karim Naaji <karim.naaji@gmail.com>
    mourner and karimnaaji authored Feb 4, 2022
    Copy the full SHA
    0b86ef3 View commit details

Commits on Feb 7, 2022

  1. Copy the full SHA
    f834a8a View commit details
  2. Copy the full SHA
    9be1d7a View commit details
  3. Copy the full SHA
    8ffd197 View commit details

Commits on Feb 8, 2022

  1. [Flow] Add minor missing types to misc files (#11485)

    * add minor missing types to misc files
    
    * add missing export types for transform.js
    mourner authored Feb 8, 2022
    Copy the full SHA
    566fd39 View commit details
  2. Copy the full SHA
    965a1eb View commit details
  3. Copy the full SHA
    a399c33 View commit details
  4. [Flow] Improve types in vectortile_to_geojson.js (#11479)

    * improve vectortile_to_geojson types
    
    * fixup
    mourner authored Feb 8, 2022
    Copy the full SHA
    23a2062 View commit details
  5. Copy the full SHA
    17589c7 View commit details

Commits on Feb 9, 2022

  1. [Flow] Add missing export types to source/* (#11486)

    * [Flow] Add missing export types to source/*
    
    * [Flow] Add missing export types to source/*
    
    * ignore that background and sky layers don't have a source in queryRenderedFeatures
    
    * ignore some incompatible-call
    
    * geojson types fixup
    
    * small fixup
    
    Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com>
    stepankuzmin and mourner authored Feb 9, 2022
    Copy the full SHA
    e28580b View commit details
  2. Copy the full SHA
    30f1981 View commit details
  3. Copy the full SHA
    9f78018 View commit details

Commits on Feb 10, 2022

  1. Copy the full SHA
    a9f540d View commit details
  2. Change map.getProjection() to return always return explicitly set glo…

    …be, projection refactoring and optimization (#11460)
    
    * Removing redundant call to setProjection on Transform.clone
    
    * Fix Typo
    
    * Early exit before notifying workers if projection has not changed
    
    * Returns projection with name globe when map is transitioned to Mercator
    
    * Added map._explicitProjection
    
    * Moving projection update logic from style into map.js
    
    * Add comments and change variable names
    
    * Update unit tests
    
    * Moving logic from map.setProjection into map.updateProjection
    
    * Removing _transitionFromGlobe boolean and previous _updateProjection function, consolodating logic in updateProjection
    
    * Change name of style.tryDraping to enableDraping
    
    * Removing null option to map.updateProjection
    
    * Consolidating map.updateProjection into map.setProjection
    
    * Correctly fallback to stylesheet projection
    
    * Removing `_runtimeProjection`
    
    * Fixed setProjection(null), improved unit tests
    
    * Apply suggestions from code review
    
    Co-authored-by: Karim Naaji <karim.naaji@gmail.com>
    
    * Changing early return to if statement, other small fixes
    
    * Refactoring logic in _updateProjection
    
    * Expanding one line if statement
    
    * Adding render tests and comment
    
    * Add globe to circle debug
    
    Co-authored-by: Karim Naaji <karim.naaji@gmail.com>
    SnailBones and karimnaaji authored Feb 10, 2022
    Copy the full SHA
    47479ce View commit details

Commits on Feb 11, 2022

  1. Copy the full SHA
    9e604f8 View commit details
  2. [Flow] Add missing export types to handler/* (#11503)

    * [Flow] Add missing export types to handler/*
    stepankuzmin authored Feb 11, 2022
    Copy the full SHA
    713882b View commit details
  3. Copy the full SHA
    3483ba7 View commit details

Commits on Feb 12, 2022

  1. [Flow] Add missing export types to style/style_layer/* (#11506)

    * [Flow] Add missing export types to style/style_layer/*
    
    Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com>
    stepankuzmin and mourner authored Feb 12, 2022
    Copy the full SHA
    2730cf5 View commit details

Commits on Feb 15, 2022

  1. Simplify globe buffers code (#11500)

    * simplify globe buffers code
    
    * optimize and simplify globe pole drawing
    
    * fixup
    mourner authored Feb 15, 2022
    Copy the full SHA
    e862564 View commit details

Commits on Feb 16, 2022

  1. Copy the full SHA
    07872e1 View commit details
  2. Simplify web worker registry to reduce bundle size (#11511)

    * simplify web worker registry; remove redundant class name argument
    
    * fix AJAXError transfer
    
    * fixup
    mourner authored Feb 16, 2022
    Copy the full SHA
    f2b4db0 View commit details
Loading