-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Comparing changes
Open a pull request
base repository: mapbox/mapbox-gl-js
base: v2.9.2
head repository: mapbox/mapbox-gl-js
compare: v2.10.0
Commits on May 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 128e82b - Browse repository at this point
Copy the full SHA 128e82bView commit details
Commits on May 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8d4417b - Browse repository at this point
Copy the full SHA 8d4417bView commit details -
Adding test for globe marker rotation (#11890)
* Fix ignoring marker rotation for map-aligned markers on globe * Adding test for globe marker rotation
Configuration menu - View commit details
-
Copy full SHA for f294c74 - Browse repository at this point
Copy the full SHA f294c74View commit details
Commits on May 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b51ea41 - Browse repository at this point
Copy the full SHA b51ea41View commit details -
Add support for
unit
inNumberFormat
(#11839)* Add support for `unit` in `NumberFormat` * Add test for `unit` in `NumberFormat` * Update docs for `unit` NumberFormat
Configuration menu - View commit details
-
Copy full SHA for 3228854 - Browse repository at this point
Copy the full SHA 3228854View commit details -
Configuration menu - View commit details
-
Copy full SHA for e114f26 - Browse repository at this point
Copy the full SHA e114f26View commit details
Commits on May 18, 2022
-
Add filter features within map view with globe release test (#11888)
* add filter features within map view with globe release test
Configuration menu - View commit details
-
Copy full SHA for facf404 - Browse repository at this point
Copy the full SHA facf404View commit details -
Adding rotationAlignment: 'horizon' for markers on globe (#11894)
Co-authored-by: Karim Naaji <karim.naaji@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2ad1134 - Browse repository at this point
Copy the full SHA 2ad1134View commit details -
Fix incorrect circle bucket up direction (#11904)
* Fix for https://github.com/mapbox/mapbox-gl-native-internal/issues/3426 * Update baselines
Configuration menu - View commit details
-
Copy full SHA for 844766c - Browse repository at this point
Copy the full SHA 844766cView commit details
Commits on May 20, 2022
-
ScaleControl: add i18n support (#11850)
* ScaleControl: add i18n support * hardcode nautical miles as `nm` for all locales
Configuration menu - View commit details
-
Copy full SHA for 88fcbc9 - Browse repository at this point
Copy the full SHA 88fcbc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 119227f - Browse repository at this point
Copy the full SHA 119227fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0e0f56 - Browse repository at this point
Copy the full SHA c0e0f56View commit details
Commits on May 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9ac6e6d - Browse repository at this point
Copy the full SHA 9ac6e6dView commit details -
Fix potential flickering on image source updates (#11928)
* Fix flickering of image source on reload * Add unit tests
Configuration menu - View commit details
-
Copy full SHA for 178789b - Browse repository at this point
Copy the full SHA 178789bView commit details -
Fix setStyle breaking with globe view (#11913)
* set draping for terrain * use map option for terrain draping check * move to one line * wip: add render test * fixed error with render test * demonstrate issue with mercator * fix background id to update in second setStyle call * bring zoom out to show sphere * Updating expected.png * better readability * fix conditional * fix lint Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
Configuration menu - View commit details
-
Copy full SHA for e6d9c44 - Browse repository at this point
Copy the full SHA e6d9c44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ddb42b - Browse repository at this point
Copy the full SHA 4ddb42bView commit details -
Add video to globe release tests (#11929)
* add ozone video on globe to release tests * formatting * formatting * fix lint issues * simplify play/pause button * added atmosphere
Configuration menu - View commit details
-
Copy full SHA for 22e322b - Browse repository at this point
Copy the full SHA 22e322bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ea9b76 - Browse repository at this point
Copy the full SHA 2ea9b76View commit details -
Configuration menu - View commit details
-
Copy full SHA for b573850 - Browse repository at this point
Copy the full SHA b573850View commit details
Commits on Jun 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e9b7c0e - Browse repository at this point
Copy the full SHA e9b7c0eView commit details
Commits on Jun 4, 2022
-
Clone stylesheet to allow toggling different styles with
setStyle
(#……11942) * clone stylesheet instead of manipulating it directly * style should not contain terrain since it is no longer being overwritten * add unit test * add in default values for terrain when updating * Add test for projections * unit test for terrain exaggeration does not need sources * should have two calls to setStyle to fully test toggling * default value does not need to be added if previous terrain style also used the default value * hasOwnProperty is already a boolean * no need to check currSpec because checks for deep equals and 1 is already set for default * fix unit tests * fix style setting in unit test * accidental deletion * switch to deep clone from extend * better way to find default value * use hasOwnProperty instead * convert to false from undefined * create reusable function for setting transition parameters * update _setTransitionParameters * mix up between duraton/delay values * reduce repetitive code to update style spec and transitions between terrain and fog * revert change
Configuration menu - View commit details
-
Copy full SHA for 285b5f7 - Browse repository at this point
Copy the full SHA 285b5f7View commit details
Commits on Jun 7, 2022
-
minimize scale changes when panning in globe view (#11951)
* adjust scale at low zoom levels in globe view * improve * Adding render test catching missing tiles with minzoom * Allowing lower zoom level tiles toward the poles * Fix lint * Updating render tests to pass * Updating tolerances to fix failing tests * Updating one more tolerance * Fixing query tests * use GLOBE_ZOOM_THRESHOLD_MIN * rename to mercatorScaleRatio * add comment about matching scale * avoid recentering on terrain if rendering globe * update unit tests * lint Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
Configuration menu - View commit details
-
Copy full SHA for 3424632 - Browse repository at this point
Copy the full SHA 3424632View commit details -
Do not set the map language to the user's preferred language by defau…
…lt (#11952) * Do not set the map language to the user's preferred language by default * fix unit test * cleanup * cleanup * fix worldview setter
Configuration menu - View commit details
-
Copy full SHA for b456388 - Browse repository at this point
Copy the full SHA b456388View commit details
Commits on Jun 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 970f259 - Browse repository at this point
Copy the full SHA 970f259View commit details -
Reload tiles after TileJSON is loaded in VectorTileSource#setSourcePr…
…operty (#11963) * Reload tiles after TileJSON is loaded in setSourceProperty * add more i18n tests * drop the language validation * mark i18n API as private
Configuration menu - View commit details
-
Copy full SHA for 41c4f71 - Browse repository at this point
Copy the full SHA 41c4f71View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb3bed2 - Browse repository at this point
Copy the full SHA bb3bed2View commit details
Commits on Jun 9, 2022
-
Disable custom anti-aliasing when terrain exaggeration is > 0 (#11977)
* Disable custom anti-aliasing when terrain exaggeration is > 0 * Fix flow
Configuration menu - View commit details
-
Copy full SHA for af9d108 - Browse repository at this point
Copy the full SHA af9d108View commit details
Commits on Jun 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for debb666 - Browse repository at this point
Copy the full SHA debb666View commit details -
Add render tests for validating fog parameters on style change (#11990)
* Add render tests for validating fog parameters on style change * update ignores.json
Configuration menu - View commit details
-
Copy full SHA for 83881c4 - Browse repository at this point
Copy the full SHA 83881c4View commit details
Commits on Jun 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c8a291b - Browse repository at this point
Copy the full SHA c8a291bView commit details -
Fix symbols not rendering on globe after style change (#11999)
* Broadcast setProjection event on all style changes * Adding render test * Apply updates before triggering new frame
Configuration menu - View commit details
-
Copy full SHA for b1c54af - Browse repository at this point
Copy the full SHA b1c54afView commit details
Commits on Jun 16, 2022
-
Fix precision errors in pack/unpack depth (#12005)
Current code is introducing precision errors in the pack/unpack depth functions by not using the correct range of values. When the packed_depth is written to R8G8B8A8 texture the maximum value it can store is 255 per channel, not 256. We were introducing errors in the third decimal in a range from 0..1. Seems this code was also wrong in three.js and other libraries, hence the confusion. Coded a godbolt to prove the issue (https://godbolt.org/z/8MrrhPh11). This fix also helps in gl-native terrain occlusion and shadow rendering, as otherwise artifacts are visible
Configuration menu - View commit details
-
Copy full SHA for f49831e - Browse repository at this point
Copy the full SHA f49831eView commit details -
Add extra constrain to avoid unnecessary line shader calculations if …
…'line-trim-offset' is not set (#12004) * Add extra constrains for the line-trim-offset calculation in shader * rename the macro and add the macro value when line-trim-offset is enabled * fix lint issue * Fix preprocess preconditions
Configuration menu - View commit details
-
Copy full SHA for 8e66136 - Browse repository at this point
Copy the full SHA 8e66136View commit details -
Doc changes for globe view (#12002)
* Add globe to map.options * Update fog example to include all new properties * Update style spec to reflect new limitations * Update src/ui/map.js Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com> * Update src/ui/map.js Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com> * Update src/style-spec/reference/v8.json Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com> * Update projection link Co-authored-by: Aidan H <aidan.hendrickson@mapbox.com>
Configuration menu - View commit details
-
Copy full SHA for 4d051bc - Browse repository at this point
Copy the full SHA 4d051bcView commit details -
Relaxed behavior for unsupported globe APIs (#12008)
* Relaxed unsupported globe APIs to prevent some plugin from being unusable Fixup * Update error message
Configuration menu - View commit details
-
Copy full SHA for 19ec68b - Browse repository at this point
Copy the full SHA 19ec68bView commit details
Commits on Jun 17, 2022
-
Prevent flickering of symbols during globe mercator transition (#11957)
* Prevent flickering of symbols during globe mercator transition * Fixup * Simplify extraneous statement * Fix placement of mixed symbol tiles into the collision index * Revert debug changes * Better variable name + fix flow * Refactor and cleanups * Ensure correct tile matrix with assert and fix order of operation when updating the projection for placement and collision index tile matrix * Add some documentation to `pixelSpaceConversion` * Fix bad merge
Configuration menu - View commit details
-
Copy full SHA for 6c69aec - Browse repository at this point
Copy the full SHA 6c69aecView commit details -
Fix geolocate control on globe (#12009)
* Fix geolocate control with Globe View * Combine examples * Add unit test
Configuration menu - View commit details
-
Copy full SHA for f34b72f - Browse repository at this point
Copy the full SHA f34b72fView commit details -
Fix setting fog default values when calling setStyle (#11992)
* fix using default params with fog * Fix flow issue * remove default values checks from fog.js * remove checking old style spec to take default * fixed typos * no longer takes in old style spec in fog.set * add unit test * should pass render test * fix skip accidentally added render test * unwanted deletion from ignores.json * fix render test pass, and allowing default values to pass when using map.setFog({}) * fix flow and lint issues * fix some broken tests * conditional order importance * check in diff not working * working locally render test should pass * this functionality of using previous style without removing fog needs refactoring - not yet supported in gl js * added wait operation for render test to pass * should pass test * adding render test, expected.png not generating * typos, but still can't generate image * fix test, add expected.png * add allowed
Configuration menu - View commit details
-
Copy full SHA for 8d36a15 - Browse repository at this point
Copy the full SHA 8d36a15View commit details -
Refactor circle and heatmap layer rendering on globe (#11931)
* Fix circle layer scale and alignment properties on globe * Update render test baselines * Skip query test for now Co-authored-by: Karim Naaji <karim.naaji@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6426367 - Browse repository at this point
Copy the full SHA 6426367View commit details
Commits on Jun 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 18f1fe3 - Browse repository at this point
Copy the full SHA 18f1fe3View commit details -
fix line-trim-offset shader (#12017)
* fix line-trim-offset shader * fix line-trim-offset check
Configuration menu - View commit details
-
Copy full SHA for b8b4e8a - Browse repository at this point
Copy the full SHA b8b4e8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e65f1f9 - Browse repository at this point
Copy the full SHA e65f1f9View commit details -
Fill extrusion ambient occlusion (#11926)
* Faux ambient occlusion specialized for buildings Styleable layout property fill-extrusion-faux-ao (boolean). Implementation in shaders done under #ifdef FAUX_AO not to affect other use cases. This is a low cost approach that potentially combined with line-blur (TODO: line-blur artefacts issue #10000) provides plausible results, somewhat reminding of ambient occlusion. The approach shades vertical walls vertically near ground and horizontally near concave angles. In contrast to vertical-gradient that's linearly interpolated in fragment shader, exponential shading is exponential Implementation is specialized for scale of buildings. Open for later introduction of data constant paint property fill-extrusion-faux-ao-radius (in meters). E.g. defgault value of 3 would correspond to this implementation. Arguably, data visualizations on globe zoom levels benefit more from vertical-gradient that is linearly interpolated from ground to top than from this since in most of use cases there are no concave angles. Setting the property also activates an improvement for #3324 - z-fighting artefacts are especially noticeable on buildings. This improvement could be promoted to all the cases later. As it would take time to re-evaluate if the fix is acceptable for all the cases, it is enabled in shaders under #ifdef FAUX_AO. The appropach is based on common z-fighting culprits coming from overlapping fill extrusion walls that have different height and different base. In such case, higher planes and those with higher base (since often height is the same) are brought forward. * AO: Replace faux-ao layout boolean by intensity and radius paint properties Instead of fill-extrusion-faux-ao layout constant property, 2 paint properties are introduced: - fill-extrusion-ambient-occlusion-intensity, in range [0..1] - fill-extrusion-ambient-occlusion-radius, in meter units, values larger than 0. Reasons: - is it too early top specify layout property that would be use as a hard switch of the feature. In future, we might have multiple types of AO (server side included) where type of AO would be used, not a boolean property. - separate properties intensity and radius are needed for globe zoom level visualization and those properties are expected when modelling AO, e.g. similar is found in Blender. * Fill extrusion z fighting render test, fill extrusion pattern support for AO With ambient occlusion intensity of 0.001, expected result is the same as with no ambient occlusion, but with z fighting fixed. * Render tests, process review comments. Shaders: removed sqrt and mix-es that are using constants Thanks @karimnaaji * Process review comments. Render tests for small angles * Link to documentation in shader code. Processing the latest comments and rebase.
Configuration menu - View commit details
-
Copy full SHA for 6348a20 - Browse repository at this point
Copy the full SHA 6348a20View commit details
Commits on Jun 21, 2022
-
flat-roof-ao render test transition duration set to 0 (#12022)
In gl-native, this render test is flaky/incorrect as it transitions to light set in the operation. Transition set to 0 makes is transition to new light in gl js and the same behavior as in gl-native
Configuration menu - View commit details
-
Copy full SHA for aaa4ee5 - Browse repository at this point
Copy the full SHA aaa4ee5View commit details -
Refactoring globe tile position calculation (#11987)
* Refactoring globe tile code * Small verbacity improvement * Undoing logic change to scale in calculateGlobeMercatorMatrix * Update src/geo/projection/globe_util.js Co-authored-by: Karim Naaji <karim.naaji@gmail.com> * Changing tileScale to tileCount Co-authored-by: Karim Naaji <karim.naaji@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for aac1eac - Browse repository at this point
Copy the full SHA aac1eacView commit details
Commits on Jun 22, 2022
-
Add shadow rendering to shaders (#11985)
* Shadow rendering shader changes - Receive shadows on fill extrusions - Shadow rendering with terrain * Fix various issues with shadow shaders - Fix fill extrusion apply fog - Remove duplicate shadow prelude - Remove unused uniform in terrain_raster - Reorganize shadow shader code and fix metal rendering - Move unpack_depth to general prelude.fragment - Fix shadow prelude - Fixes for OpenGL * Address review comments * Address review comments and other fixes - Allow use of pack_depth in all fragment shaders - Rename fill_extrusion_shadow to fill_extrusion_depth - Don't use mix() in shadow prelude - Don't process shadow specific shaders - Don't inset fill extrusions into the ground for shadow map - Remove bias from shadows without normals * Address review comments - Removed min() call from shadow pos.z - Added early exit to shadowed_color_normal() - Added comment about the shadow sampling method Co-authored-by: Mikko Pulkki <mikko.pulkki@mapbox.com> * Add highp precision for unpack_depth function * Revert earlier change, as further testing revealed an issue Co-authored-by: Mikko Pulkki <mikko.pulkki@mapbox.com> Co-authored-by: Jordi Torres <jtorresfabra@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a0b7d7 - Browse repository at this point
Copy the full SHA 5a0b7d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80e5afd - Browse repository at this point
Copy the full SHA 80e5afdView commit details
Commits on Jun 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 283442c - Browse repository at this point
Copy the full SHA 283442cView commit details
Commits on Jun 29, 2022
-
Optimize tile calculations for globe (#12050)
* eliminate matrix allocation in aabbForTileOnGlobe * less array allocations in aabbForTileOnGlobe * simplify globeECEFNormalizationScale * less globe matrix allocations
Configuration menu - View commit details
-
Copy full SHA for 147c385 - Browse repository at this point
Copy the full SHA 147c385View commit details
Commits on Jun 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fb857af - Browse repository at this point
Copy the full SHA fb857afView commit details
There are no files selected for viewing