Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Sync fill-extrusion-pattern sides rendering with GL-JS implementation #15268

Open
astojilj opened this issue Jul 31, 2019 · 1 comment · May be fixed by #15309
Open

[core] Sync fill-extrusion-pattern sides rendering with GL-JS implementation #15268

astojilj opened this issue Jul 31, 2019 · 1 comment · May be fixed by #15309
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS

Comments

@astojilj
Copy link
Contributor

The issue behind failing fill-extrusion-pattern tests on GL native looks like having a different cause from mapbox/mapbox-gl-js#3327:
it is related to mapbox/geojson-vt-cpp#44 and usage of fixupPolygons / wagyu here:

mapbox-gl-native/src/mbgl/tile/geojson_tile_data.hpp

Line 32 in 273ad43

// https://github.com/mapbox/geojson-vt-cpp/issues/44
.

As the order is different, edgedistance used for fill-extrusion-pattern side shader is different from gl-js. Tests now fail but are ignored.
@astojilj astojilj added GL JS parity For feature parity with Mapbox GL JS Core The cross-platform C++ core, aka mbgl labels Jul 31, 2019
@astojilj astojilj self-assigned this Jul 31, 2019
@astojilj astojilj changed the title [core] Sync fill-extrusion-pattern sides rendering from GL-JS [core] Sync fill-extrusion-pattern sides rendering with GL-JS implementation Jul 31, 2019
@astojilj astojilj removed their assignment Jul 31, 2019
@astojilj
Copy link
Contributor Author

This is related to #8746 - while the issue #8746 is closed, ring order (input to classifyRings) in e.g. fill-extrussion-pattern/@2x render test between GL-JS and GL-native is different.

This was referenced Aug 4, 2019
Open
Draft
astojilj added a commit that referenced this issue Aug 6, 2019
@astojilj
Restore point order in polygons that don't require fixup
131ce55 
wagyu algorithm setup and checking if polygon fixup is required is expensive as much as fixing it - so we continue running wagyu for all geojson and, if attempt to restore original point order after wagyu.  Even with no polygon fixup, starting point in rings is changed.  This causes a disparity between GL-JS and GL-native, visible in implementation of fill-extrusion pattern.

Fixes: #15268
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore ring start point after wagyu mapbox/mapbox-gl-native
1 participant
@astojilj