Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid PrivacyInfo in v2.0.0 - Unable to submit binary to App Store #233

Closed
jeffypooo opened this issue May 3, 2024 · 15 comments
Closed

Comments

@jeffypooo
Copy link

jeffypooo commented May 3, 2024

Unable to distribute binaries with mapbox-search-ios v2.0.0 due to invalid PrivacyInfo file in MapboxCoreSearch.framework

TMS-91064: Invalid tracking information - A PrivacyInfo.xcprivacy file contains invalid tracking information at the following path: “Frameworks/MapboxCoreSearch.framework/PrivacyInfo.xcprivacy”. NSPrivacyTracking must be true if NSPrivacyTrackingDomains isn‘t empty. Keys and values in your app’s privacy manifest must be valid. For more details about privacy manifest files, visit: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files.
@jeffypooo
Copy link
Author

This is still present in v2.0.1 @aokj4ck

This is blocking us from releasing any app updates, please fix

@jeffypooo
Copy link
Author

We tried adding our own PrivacyInfo.xcprivacy file with tracking set to NO and still encounter the same problem. Will try setting it to YES and see what happens.

@jeffypooo
Copy link
Author

Setting to YES also does not work.

@jeffypooo jeffypooo changed the title Missing PrivacyInfo in v2.0.0 - Unable to submit binary to App Store Invalid PrivacyInfo in v2.0.0 - Unable to submit binary to App Store May 5, 2024
@aokj4ck
Copy link
Contributor

aokj4ck commented May 6, 2024

@jeffypooo ah yes sorry about that. I'm working on a new release to fix this starting with our v1 branch and then updating v2 immediately after. Thank you for your patience.

@jeffypooo
Copy link
Author

@aokj4ck okay sounds good! Thank you!

@jeffypooo
Copy link
Author

jeffypooo commented May 6, 2024

Just in case it's useful for others, I added a ci_pre_xcodebuild.sh script that finds all of the privacy files in MapboxCoreSearch and deletes them. This seems to have worked for us re: submission to external beta testers:

#!/bin/zsh


DEFAULT_DERIVED_DATA_PATH="${HOME}/Library/Developer/Xcode/DerivedData"

DERIVED_DATA_PATH=${CI_DERIVED_DATA_PATH:-$DEFAULT_DERIVED_DATA_PATH}

echo "Derived data path = ${DERIVED_DATA_PATH}"

# Find all .xcprivacy files in MapboxCoreSearch artifacts and nuke them
privacy_files=($(find $DERIVED_DATA_PATH -type f -path '*/MapboxCoreSearch.xcframework/*.xcprivacy'))
for file in $privacy_files; do
    echo "Deleting $file"
    rm -f ${file}
done

Note: this is intended for Xcode Cloud, but a similar approach should work as a Run Script phase of your build.

@james-wag
Copy link

When can we expect a patched v1 release? I take it will be (v1.0.2)?

@jeffypooo
Copy link
Author

@aokj4ck if useful, this tool can scan your project and generate a correct PrivacyInfo.xcprivacy file: https://github.com/stelabouras/privacy-manifest

I've used it elsewhere and it works well.

@aokj4ck
Copy link
Contributor

aokj4ck commented May 9, 2024

@james-wag @jeffypooo I am working on updates for v1 and v2 releases to fix this and I'll keep you posted as soon as these are available.

@james-wag
Copy link

james-wag commented May 10, 2024

Hi @aokj4ck , I pulled the latest Mapbox iOS Search SDK v1.0.2 release branch and ran carthage to populate the MapboxCoreSearch and MapboxCommon dependencies. However, MapboxCoreSearch's PrivacyInfo.xcprivacy file still seems to have the NSPrivacyTracking key set to false. But the OP's original app store submission error indicates it needs to be set to true.

I haven't tried submitting a new app build with v1.0.2 yet, but just wanted to raise this observation since it doesn't look like the original issue has been fixed yet.

@aokj4ck
Copy link
Contributor

aokj4ck commented May 14, 2024

@jeffypooo @james-wag the corrected PrivacyInfo.xcprivacy is available in our latest release v2.0.3, please try that and let me know if you encounter any issues. https://github.com/mapbox/mapbox-search-ios/releases/tag/v2.0.3

@james-wag
Copy link

james-wag commented May 14, 2024

@aokj4ck I pulled v2.0.3 and the MapboxCoreSearch's PrivacyInfo.xcprivacy file looks good now. Will this patch be coming to a v1.0.3 also?

@aokj4ck
Copy link
Contributor

aokj4ck commented May 15, 2024

@james-wag I have already corrected the PrivacyInfo.xcprivacy in v1.0.2 (using MapboxCoreSearch v1.0.7), https://github.com/mapbox/mapbox-search-ios/releases/tag/v1.0.2 If you're using the v1 series please try this release and let me know if any problems arise.

@aokj4ck
Copy link
Contributor

aokj4ck commented May 28, 2024

@jeffypooo @james-wag are these problems you encountered solved for you or do you still have MapboxSearch errors?

@jeffypooo
Copy link
Author

This looks to be fixed now ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants