Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prebuilt: add electron 6.1 & 7 #1237

Merged
merged 7 commits into from
Nov 14, 2019
Merged

prebuilt: add electron 6.1 & 7 #1237

merged 7 commits into from
Nov 14, 2019

Conversation

kewde
Copy link
Collaborator

@kewde kewde commented Oct 28, 2019

No description provided.

@kewde kewde closed this Oct 28, 2019
@kewde kewde reopened this Oct 28, 2019
@kewde
Copy link
Collaborator Author

kewde commented Oct 29, 2019

I will have to bump the version of Node for the build process of electron 7.x because it's using the asynckeyword which is available as part of Node.js since version 7.10.1. It's currently using 6.

@jackple
Copy link

jackple commented Nov 11, 2019

Is there a certain time about bumping the version of Node? @kewde

@kewde
Copy link
Collaborator Author

kewde commented Nov 11, 2019

@jackple I'm working on it today. I have two bugs to resolve before I can do a release.

@jackple
Copy link

jackple commented Nov 11, 2019

@kewde Thanks a lot! I'm using electron 6.x and I've got a few problems that only upgrading to 7.x could help me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants