deps: alternative update of node-gyp for electron (v5 & v6), windows #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
node-pre-gyp seems to be falling back to node-gyp which is installed in: Including node-gyp into the package does not help, neither does installing it globally with the -g flag. |
|
The updated version that we want node-pre-gyp to use is present at |
force an updated version into the directory that node-pre-gyp uses to fetch node-gyp from "C:\Program Files\nodejs\node_modules\npm\node_modules"
|
@bruce-one It's a long shot, but I could use someone to take a look at this because it's driving me crazy. This should be a simple batch change yet I can't get it right. |
|
Well, apparently it's fixed now. Will release soon! |
|
Awesome! Sorry I wasn't able to offer any help... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.