Rebuild binaries before publishing #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executing "npm install --build-from-source" only builds the module for one of the N-API target versions. The build command has to be executed explicitly to generate builds targeting each of the specified N-API versions. This should fix publishing binaries.
|
@kewde Could you take a look at this? |
|
@kewde Thanks for the merge, this is very much appreciated. Could you also consider re-publishing the binaries or doing a new release to properly fix the linked issue? |
|
@nickrum going to attempt to patch the bins for v5.0.1, I can not overwrite existing binaries but I can attempt to have it add the N-API v6 bins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing "npm install --build-from-source" only builds the module for one of the N-API target versions. The build command has to be executed explicitly to generate builds targeting each of the specified N-API versions.
This should fix publishing binaries (which means this should fix #1424).