Use isolates to encode features #367
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setFeatureForGeoJsonSources use compute to encode multiple geojsonFeatures without blocking the main isolate
T-moz
force-pushed
the
use-isolates-for-encoding-features
branch
from
7028d44
to
6f34e48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366
Wrapping
jsonEncodein acomputeallow data encoding without blocking the main isolate.BUT
Spawning multiple isolate is very expensive, and can lead to crash.
So this technique is better used when encoding multiple geojsonFeature.
Currently, I have a performance issues on my app, when updating multiple lines.
So I coded a fix that solves only this issue.
But this principle could be applied to symbols, circles, polygones, and to the method
setGeoJsonSource.I willing to work on this, but first, I need review and feedbacks on this first implementation 🙏.