Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate maplibre-native for iOS to version 6.4.2 #405

Merged
merged 13 commits into from
Jun 3, 2024

Conversation

josxha
Copy link
Collaborator

@josxha josxha commented May 16, 2024

This pull request updates the maplibre-native version to 6.4.1 for iOS. Before the unstable version 5.14.0-pre3 was used.

The iOS changelog for maplibre-native can be viewed here (only iOS Devices with an Apple A7 GPU or later are supported from now on).

All CI workflows passed in my fork.

Closes #388

@josxha josxha marked this pull request as ready for review May 16, 2024 12:54
@josxha josxha changed the title feat!: update maplibre-native for ios to version 6.4.1 feat: migrate maplibre-native for iOS to version 6.4.1 May 16, 2024
@josxha josxha changed the title feat: migrate maplibre-native for iOS to version 6.4.1 feat!: migrate maplibre-native for iOS to version 6.4.1 May 16, 2024
@josxha josxha changed the title feat!: migrate maplibre-native for iOS to version 6.4.1 feat!: migrate maplibre-native for iOS to version 6.4.1 May 16, 2024
@josxha josxha linked an issue May 20, 2024 that may be closed by this pull request
@josxha josxha added this to the v0.20.0 milestone May 20, 2024
@josxha josxha self-assigned this May 20, 2024
@josxha josxha force-pushed the feature/maplibre-ios-6.4.1 branch from b266009 to d342d5a Compare May 21, 2024 15:35
@josxha josxha linked an issue May 28, 2024 that may be closed by this pull request
@josxha josxha requested a review from kuhnroyal May 29, 2024 17:37
@kuhnroyal
Copy link
Collaborator

Confirmed that with this change, the example runs on 17.4 iOS simulator.

Copy link
Collaborator

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog entry?

@josxha josxha changed the title feat!: migrate maplibre-native for iOS to version 6.4.1 feat!: migrate maplibre-native for iOS to version 6.4.2 Jun 3, 2024
@josxha
Copy link
Collaborator Author

josxha commented Jun 3, 2024

I updated the changelog and bumped the version to 6.4.2 to include the latest patch. 👍

@josxha josxha merged commit 9c4355d into maplibre:main Jun 3, 2024
9 checks passed
@josxha josxha deleted the feature/maplibre-ios-6.4.1 branch June 3, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plans to upgrade to MapLibre Native iOS 6.0.0 Crash on iOS 17.4 simulator
2 participants