Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MapLibre GL JS Shaders after the TypeScript Migration #293

Closed
wipfli opened this issue May 28, 2022 · 3 comments
Closed

Update MapLibre GL JS Shaders after the TypeScript Migration #293

wipfli opened this issue May 28, 2022 · 3 comments

Comments

@wipfli
Copy link
Member

wipfli commented May 28, 2022

MapLibre GL Native is using the shaders from MapLibre GL JS before the TypeScript migration. I am worried about changing the shaders in GL JS if we cannot test the consequences in native.

@birkskyum created a branch to use the shaders after the TypeScript migration: https://github.com/maplibre/maplibre-gl-native/tree/generate-shaders-using-typescript

Since we forked GL JS, there have been only a hand full of updates to the shaders, see https://github.com/maplibre/maplibre-gl-js/commits/main/src/shaders for a complete list. Notable changes were:

@wipfli
Copy link
Member Author

wipfli commented May 9, 2023

@louwers should this be closed?

@louwers
Copy link
Collaborator

louwers commented May 9, 2023

@wipfli Yes we have copied them over and they are being refactored to take advantage of OpenGL ES 3.0.

I think WebGL 2 has some of the same functionality of OpenGL ES 3.0, but GL JS does not use WebGL 2 yet. In any case, keeping them in sync will need to happen manually going forward.

@louwers louwers closed this as completed May 9, 2023
@birkskyum
Copy link
Member

birkskyum commented May 9, 2023

@louwers , GL JS could very soon allow for some webgl2 though, so I have a hope that we might be able to copy some of these great changes to the shaders back to GL JS when it's ready.

maplibre/maplibre-gl-js#2497
maplibre/maplibre-gl-js#1891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants