Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark mapstruct-processor jar as Spring-Boot-Jar-Type: annotation-processor #2244

Closed
filiphr opened this issue Oct 21, 2020 · 0 comments · Fixed by #2248
Closed

Mark mapstruct-processor jar as Spring-Boot-Jar-Type: annotation-processor #2244

filiphr opened this issue Oct 21, 2020 · 0 comments · Fixed by #2248
Assignees
@filiphr
Labels
enhancement
Milestone
1.4.2

Comments

@filiphr
Copy link
Member

filiphr commented Oct 21, 2020

Add Spring-Boot-Jar-Type: annotation-processor to the mapstruct-processor manifest.

This would make sure that even if users have the mapstruct-processor jar as a Maven provided dependency the spring-boot-maven-plugin will not include it in the fat jar.

spring-projects/spring-boot#22036

spring-projects/spring-boot@fa1d4a4
@filiphr filiphr added this to the 1.4.2 milestone Oct 21, 2020
@filiphr filiphr self-assigned this Oct 21, 2020
filiphr added a commit to filiphr/mapstruct that referenced this issue Oct 24, 2020
@filiphr
mapstruct#2244 Mark mapstruct-processor jar as Spring-Boot-Jar-Type: …
838c7df 
…annotation-processor

Doing this would make sure that starting from Spring Boot 2.4 the mapstruct-processor will not be included in the fat jar produced by the Spring Boot maven plugin if people have it as a maven provided dependency.

This is an alternative if people are not using the maven-compiler-plugin annotationProcessorPaths
@filiphr filiphr mentioned this issue Oct 24, 2020
Merged
filiphr added a commit that referenced this issue Oct 28, 2020
@filiphr
#2244 Mark mapstruct-processor jar as Spring-Boot-Jar-Type: annotatio…
3256abb 
…n-processor

Doing this would make sure that starting from Spring Boot 2.4 the mapstruct-processor will not be included in the fat jar produced by the Spring Boot maven plugin if people have it as a maven provided dependency.

This is an alternative if people are not using the maven-compiler-plugin annotationProcessorPaths
filiphr added a commit to filiphr/mapstruct that referenced this issue Jan 31, 2021
@filiphr
mapstruct#2244 Mark mapstruct-processor jar as Spring-Boot-Jar-Type: …
b90c0a9 
…annotation-processor

Doing this would make sure that starting from Spring Boot 2.4 the mapstruct-processor will not be included in the fat jar produced by the Spring Boot maven plugin if people have it as a maven provided dependency.

This is an alternative if people are not using the maven-compiler-plugin annotationProcessorPaths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filiphr filiphr

Labels
enhancement
Projects
None yet
Milestone
1.4.2
Development

Successfully merging a pull request may close this issue.

#2244 Mark mapstruct-processor jar as Spring-Boot-Jar-Type: annotation-processor filiphr/mapstruct
1 participant
@filiphr