Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test-utils a separate module #2892

Open
Zegveld opened this issue Jun 17, 2022 · 1 comment · May be fixed by #2904
Open

Make test-utils a separate module #2892

Zegveld opened this issue Jun 17, 2022 · 1 comment · May be fixed by #2904

Comments

@Zegveld
Copy link
Contributor

Zegveld commented Jun 17, 2022

The mapstruct test-utils are handy for testing code generators.
I would like to also use these test-utils for testing our generators.

Can this be supplied as a separate module from the rest of the code.
Zegveld added a commit to rigd-loxia/mapstruct that referenced this issue Jun 20, 2022
@Zegveld
mapstruct#2892: extract test package to separate class. replace Abstr…
cf93326 
…actCharSequenceAssert with AbstractStringAssert.
Zegveld added a commit to rigd-loxia/mapstruct that referenced this issue Jun 20, 2022
@Zegveld
mapstruct#2892: TestUtils moved to separate module.
990be31
Zegveld added a commit to rigd-loxia/mapstruct that referenced this issue Jun 20, 2022
@Zegveld
mapstruct#2892: move package and processor definition class loader in…
e8f15c9 
…formation to ProcessorTestConfiguration.
Zegveld added a commit to rigd-loxia/mapstruct that referenced this issue Jun 20, 2022
@Zegveld
mapstruct#2892: removed all mapper specific information from Generate…
4d9df38 
…dSource class.
Zegveld added a commit to rigd-loxia/mapstruct that referenced this issue Jun 21, 2022
@Zegveld
mapstruct#2892: moved checkstyle resource to ProcessorTestConfiguration.
f18ccba
@Zegveld Zegveld linked a pull request Jun 21, 2022 that will close this issue
Open
5 tasks
Zegveld added a commit to rigd-loxia/mapstruct that referenced this issue Jun 22, 2022
@Zegveld
mapstruct#2892: Moved checkstyle back to processor.
8b31ff3
@Zegveld
Copy link
Contributor Author

Zegveld commented Jun 27, 2022

Just an update of what was discussed on gitter for reference:

Filip Hrisafov
@filiphr
jun. 21 18:54
That is great @Zegveld, I am not sure that it makes sense to put it under the org.mapstruct namespace. However, we can put it under a new namespace in a new project. If someone has an idea for a name of the project I am open for it ;)

Raimund Klein
@Chessray
jun. 21 19:03
Is ApTestUtils too prosaic?

Filip Hrisafov
@filiphr
jun. 22 08:12
Not that catchy. Maybe CompileTesting. I know that there is https://github.com/google/compile-testing. Also the testing is not always for annotation processors. It can also unit test SPIs by manually registering custom classes

Raimund Klein
@Chessray
jun. 22 12:17
OK, so let's get creative then. It's aboput the Java Compiler, so something related to coffee grinder? I'm not much of a barista myself, but can anyone think of anything?

Raimund Klein
@Chessray
jun. 22 15:13
Come to think of it, how about JBarista?

Filip Hrisafov
@filiphr
jun. 22 15:46
that is a cool name :)

Zegveld pushed a commit to rigd-loxia/mapstruct that referenced this issue Jun 28, 2022
mapstruct#2892: first draft of a README.md for the not yet created ne…
5532cd3 
…w repository.
Zegveld pushed a commit to rigd-loxia/mapstruct that referenced this issue Jun 30, 2022
mapstruct#2892: moved classes back to original location.
5c9a825
Zegveld pushed a commit to rigd-loxia/mapstruct that referenced this issue Jun 30, 2022
mapstruct#2892: import reverts.
70afda3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/2892 rigd-loxia/mapstruct
1 participant
@Zegveld