Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong globalCssToInject #100

Closed
shiyiya opened this issue Jul 4, 2023 · 3 comments
Closed

Wrong globalCssToInject #100

shiyiya opened this issue Jul 4, 2023 · 3 comments

Comments

@shiyiya
Copy link

shiyiya commented Jul 4, 2023

When I build multiple single files at the same time, some introduce CSS and some do not, but in reality, all CSS is saved to gloabl, resulting in each single file introducing all CSS.

https://github.com/marco-prontera/vite-plugin-css-injected-by-js/blob/main/src/utils.ts#L228

@marco-prontera
Copy link
Owner

Hi @shiyiya I checked the status of the legacy plugin handled officially by the Vite project. It does already inject the CSS so the code isn't required. I will release a new version of this plugin to remove the code that cause this bug since isn't more required for the plugin-legacy.
To give some additional context some people find this behavior that the plugin-legacy have a problem but for users of my plugin isn't a problem really since already the plugin do what we need.

@marco-prontera
Copy link
Owner

Hi @shiyiya the behavior is fixed, you can try the new released version v3.2.0

@shiyiya
Copy link
Author

shiyiya commented Jul 11, 2023

Great. Good work.👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants