Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double slash after hostname in compare link #22

Open
kyletaylored opened this issue Sep 21, 2021 · 6 comments
Open

Double slash after hostname in compare link #22

kyletaylored opened this issue Sep 21, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@kyletaylored
Copy link

Seeing a double slash after the hostname in the version comparison link.

image

@attiks
Copy link
Contributor

attiks commented Oct 22, 2021

I ran into the same, seems like {{owner}} isn't populated

Create a .changelog file with this

<?php

return [
  'commitUrlFormat' => '{{host}}/{{repository}}/commit/{{hash}}',
  'compareUrlFormat' => '{{host}}/{{repository}}/compare/{{previousTag}}...{{currentTag}}',
];

@marcocesarato
Copy link
Owner

Hi, to check it I need to know the repository URL format to check how the regular expression works when parsing.

@marcocesarato marcocesarato added the bug Something isn't working label Oct 22, 2021
@attiks
Copy link
Contributor

attiks commented Oct 22, 2021

$ git remote show origin -n
* remote origin
  Fetch URL: git@github.com:UN-OCHA/iasc8.git
  Push  URL: git@github.com:UN-OCHA/iasc8.git

@attiks
Copy link
Contributor

attiks commented Oct 22, 2021

Might be easier to clean the URL, replacing // with / in get....Url methods

marcocesarato added a commit that referenced this issue Oct 22, 2021
@marcocesarato
Copy link
Owner

Strange that the owner is not populated. However I have released a new version with url clean and that improve the url format detection.

@attiks
Copy link
Contributor

attiks commented Oct 22, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants