Implements Monoid interface/typeclass.
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosh
reviewed
Oct 21, 2021
src/Typeclass/Monoid.php
Outdated
| namespace Marcosh\LamPHPda\Typeclass; | ||
|
|
||
| /** | ||
| * @psalm-immutable |
There was a problem hiding this comment.
please restructure the annotations as per https://github.com/marcosh/lamphpda/blob/master/adr/2021-10-21-how-to-write-annotations.md
src/Typeclass/Monoid.php
Outdated
| * | ||
| * @return Monoid<A> | ||
| */ | ||
| public static function mempty(): Monoid; |
There was a problem hiding this comment.
mempty should return something of type A
There was a problem hiding this comment.
Job done!
Stupid question, where do you get this information from? Where is it documented that mempty should return A ?
There was a problem hiding this comment.
short answer: here
longer answer: see https://github.com/marcosh/lamphpda/blob/master/adr/2021-10-22-typeclass-instances-are-their-own-objects.md
There was a problem hiding this comment.
Excellent, thanks!!!
drupol
force-pushed
the
feat/implements-monoid-interface-typeclass
branch
from
27c4ae0
to
cfbf453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Monoidimplementations #16