Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Compose Up --wait support #308

Open
bzwieratinnovadis opened this issue Jan 7, 2024 · 0 comments
Open

Docker Compose Up --wait support #308

bzwieratinnovadis opened this issue Jan 7, 2024 · 0 comments

Comments

@bzwieratinnovadis
Copy link

This library is great, but I am missing one feature that would make it much better. Currently in order to wait for a service to become healthy, I need to use the .WaitForHttp() method. This works fine when the service becomes healthy, but when there are issues and it becomes unhealthy, I need to handle this with custom logic.
It's possible to throw a FluentDockerException inside the continuation lambda but this causes all services to be disposed before I can handle the FluentDockerException in the try-catch of the ICompositeService.Start() method. Once they are disposed, I can't retrieve the logs using host.Host.ComposeLogs(), therefore making it harder to debug what's going on in a pipeline for example.

This would all not be necessary if the --wait parameter could be passed to the docker-compose up command, which will let Docker Compose handle the health checks, rather than having custom logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant