Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with non-ASCII characters (ñ) (á) (Á) etc #118

Open
Alvy opened this issue Apr 16, 2023 · 4 comments
Open

Problem with non-ASCII characters (ñ) (á) (Á) etc #118

Alvy opened this issue Apr 16, 2023 · 4 comments

Comments

@Alvy
Copy link

Alvy commented Apr 16, 2023

There seems to be a problem with non-ASCII characters in languages other than English.

I can't edit text with letters such as the Spanish (ñ) (Ñ) or accented letters (á) (é) …

This appears to be an issue not only in the browser but also when using copy and paste from a text editor.

Additionally, linked text and tags like "#diseño" get split into something like "#dise // ño // ño," repeating after the (ñ) letter.

@kochrt
Copy link
Member

kochrt commented Apr 18, 2023

Yeah it looks like the regex for tags doesn't play well with those characters. Adding the u flag should help.

Aside from tags, what were there other issues you were noticing regarding non-ascii/unicode characters? I'll need to figure out which regexes need the flag

@Alvy
Copy link
Author

Alvy commented Apr 18, 2023

It seems to be working fine now.

  • #Tags are okay.
  • [Text in brackets for links is okay.]
  • Text outside of links is also okay.

So, great. Thank you, and keep up the good work!

@Alvy Alvy closed this as completed Apr 18, 2023
@kochrt
Copy link
Member

kochrt commented Apr 18, 2023

I haven't implemented any fixes yet - I'm glad it's working for you, but I just tried and it's still broken for me 😂

@kochrt kochrt reopened this Apr 18, 2023
@Alvy
Copy link
Author

Alvy commented Apr 18, 2023

Pretty strange; I'm using the same browser on the same file.

Anyway, the three problemes were #tags, [text in brackets] and sometimes text outside of brackets also.

I'll let you know if I notice anything again. (BTW I'm using Brave on Mac OS X.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants