Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor which allows specification of base directory #9

Open
markashleybell opened this issue Aug 26, 2016 · 1 comment
Open

Comments

@markashleybell
Copy link
Owner

If the same ignore list is used at various levels (e.g. solution root and project roots), relative rules do not get applied correctly in child paths (because rules are assumed to be relative to the overall root.

If we allowed a base directory to be passed in, we could dynamically replace the base path in any rules in the list with a forward slash, which would mean the list still worked correctly from within the base path.

@Smaug123
Copy link

@nojaf Fixing this issue would fix the bug we found in Fantomas. It's ultimately thanks to the TrimStart on https://github.com/markashleybell/MAB.DotIgnore/blob/master/MAB.DotIgnore/IgnoreRule.cs#L171 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants