Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonMark blockquote example 221 fails #696

Closed
zq1997 opened this issue Jul 31, 2020 · 4 comments
Closed

CommonMark blockquote example 221 fails #696

zq1997 opened this issue Jul 31, 2020 · 4 comments
Labels

Comments

@zq1997
Copy link

zq1997 commented Jul 31, 2020

According to commonmark spec

It is a consequence of the Laziness rule that any number of initial >s may be omitted on a continuation line of a nested block quote:

>>> foo
> bar
>>> baz

should be render to (By spec.commonmark.org and github comment system)

<blockquote>
<blockquote>
<blockquote>
<p>foo
bar
baz</p>
</blockquote>
</blockquote>
</blockquote>

but current implemention gives:

<blockquote>
<blockquote>
<blockquote>
<p>foo
bar</p>
</blockquote>
<blockquote>
<p>baz</p>
</blockquote>
</blockquote>
</blockquote>
@puzrin puzrin changed the title CommonMark strict violation CommonMark blockquote example 221 fails Jul 31, 2020
@puzrin puzrin added the bug label Jul 31, 2020
@puzrin
Copy link
Member

puzrin commented Jul 31, 2020

Thank you for report. We test CM spec automatically. Need to check why this sample was missed.

@ocavue
Copy link
Contributor

ocavue commented Aug 2, 2020

The example in the origin issue is not the example 221 in CM.

The example 221 is:

>>> foo
> bar
>>baz

Notice that there is no space before baz.

markdown-it works fine with example 221.

@zq1997
Copy link
Author

zq1997 commented Aug 2, 2020

Yeah, example 221 use two >, but I test it with three, that's why autotest didn't report this issue.

@rlidwka
Copy link
Member

rlidwka commented Sep 10, 2020

Fixed, thanks for reporting.

chrisjsewell pushed a commit to executablebooks/markdown-it-py that referenced this issue Jan 14, 2021
This commit updates the port to be up-to-date with markdown-it v11.0.1 (2020-09-14), applying two fixes:

- Fix blockquote lazy newlines, [[#696](markdown-it/markdown-it#696)].
- Fix missed mappings for table rows, [[#705](markdown-it/markdown-it#705)].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants