New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep track of line maps for "tr_open" tokens inside tbodys #705
Comments
Same for |
Mapping [rows, but without columns] is for blocks only (images are inline).
|
Right, especially since images can have arbitrary heights it would still be useful to be able to map them back to the source line when more than one image is found within the same paragraph. Otherwise I'd imagine synchronized scrolling would become somewhat unreliable under those scenarios.
Yeah that should be trivial. Would you like me to submit a PR for that? |
Since big images are usually inside separate paragraph, result is good enougth. Anyway, sourcemapping of inlines is different level of complexity and not planned.
As you wish. I hope, we will solve all pending issues at once next week. |
Fixed, looks like these were missed by accident. |
@rlidwka Actually line mapping have been added to |
- `table`, `tbody`, `tr` now have mapping - `th`, `td`, `inline` in tables do not have it close #705
- `table`, `tbody`, `tr` now have mapping - `th`, `td`, `inline` in tables do not have it close #705
- `table`, `tbody`, `tr` now have mapping - `th`, `td`, `inline` in tables do not have it close #705
- `table`, `tbody`, `tr` now have mapping - `th`, `td`, `inline` in tables do not have it close #705
Not intentional, fixed in 9fe835b. |
Awesome, thank you! |
This commit updates the port to be up-to-date with markdown-it v11.0.1 (2020-09-14), applying two fixes: - Fix blockquote lazy newlines, [[#696](markdown-it/markdown-it#696)]. - Fix missed mappings for table rows, [[#705](markdown-it/markdown-it#705)].
It looks like "tr_open" tokens have their "map" property populated only if they are inside the "thead" of a table, while "tr_open" tokens inside the "tbody" section of the table don't have their "map" property populated.
It would be useful if all "tr_open" tokens got their "map" properties populated so that scroll synchronization solutions that are built on top of that could reliably map table rows too.
The text was updated successfully, but these errors were encountered: