New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalizeLinkText mangles links containing %25 #720
Comments
Please, clarify: URL stays correct, but text corruped? Right? |
Correct. (I happened upon this via Atlassian's AtlasKit project's rich text editor, which calls normalizeLinkText directly.) |
Added |
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you normalize a URL that has something that looks like a double-escaped character, normalizeLinkText changes the meaning:
Note that the input is a Google search for the term
hello%2Fhello
; the second ishello/hello
, so normalizeLinkText has changed the meaning.(It's uncommon to do this but it is needed sometimes – what if you did want to search for
hello%2Fhello
?)Compare this to a similar example with %26:
Here, normalization knows not to convert this to
?q=hello&hello
because&
has special meaning in a URL. The same treatment that applies to%26
should apply to%25
as well because%
has special meaning in a URL too.Tested with 11.0.1.
The text was updated successfully, but these errors were encountered: