Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep copy token.attrs to avoid mutating token stream #745

Closed
wants to merge 1 commit into from
Closed

Deep copy token.attrs to avoid mutating token stream #745

wants to merge 1 commit into from

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Dec 20, 2020

Please correct me if I'm wrong but I believe this line

markdown-it/lib/renderer.js

Line 72 in be22253

tmpAttrs[i][1] += ' ' + options.langPrefix + langName;
will currently mutate the token stream.

This PR makes a deep copy of token.attrs so that mutating tmpAttrs[i] will not mutate token.attrs[i]

puzrin pushed a commit that referenced this pull request Dec 20, 2020
Avoid fenced token mutation, #745
c9949dd
@puzrin
Copy link
Member

puzrin commented Dec 20, 2020

Thanks! I did it a bit more light way.

@puzrin puzrin closed this Dec 20, 2020
@hukkin hukkin deleted the patch-1 branch December 27, 2020 20:34
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hukkin @puzrin @hukkinj1