Fix builds: remove node v0.10 from travis matrix #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
changed the title
UziTech
approved these changes
Oct 28, 2018
|
@UziTech That's a great question 🤔 I think we could say this PR itself is not breaking because it doesn't actually break compatibility with older versions of node, its just a change to CI. However, our next release that contains breaking changes (0.6.0) should mention that node v0.10 is no longer supported. It's a loop-hole but it will get CI green again and get the patch release out (0.5.2) |
Good candidate for release notes. |
|
@davisjam I will definitely add to release notes once you approve 😄 |
|
I couldn't find if we officially support any browser/versions though. I know we don't run automated tests in any browsers. So my best way to communicate v0.10 as a browser is IE. Thoughts on this one? |
davisjam
approved these changes
Oct 29, 2018
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Apr 24, 2020
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
Fix builds: remove node v0.10 from travis matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes our failing builds.
Node v0.10 went End-of-Life two years ago which is why jasmine (our test framework) won't work anymore (looks like they dropped support awhile ago and just introduced breaking changes recently.
Related: jasmine/jasmine-npm#144
Contributor
Committer
In most cases, this should be a different person than the contributor.