Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tables in a list #1446

Merged
merged 2 commits into from Mar 12, 2019
Merged

Fix tables in a list #1446

merged 2 commits into from Mar 12, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 11, 2019 •
edited

Marked version: master

Markdown flavor: GitHub Flavored Markdown

Description

Fix tables in a list

demo

* Fixes indented tables like this:

  | column1 | column2 |
  |---------|---------|
  | value1  | value2  |
  | value3  | value4  |

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

styfle
styfle approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@UziTech UziTech merged commit e540b6a into markedjs:master Mar 12, 2019
@styfle styfle mentioned this pull request Mar 25, 2019
Merged
12 tasks
@UziTech UziTech deleted the list-table branch April 23, 2019 14:29
@yoshinorin yoshinorin mentioned this pull request May 24, 2019
Closed
@541xxx 541xxx mentioned this pull request Jun 6, 2019
Closed
10 tasks
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Open
This was referenced Aug 30, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
This was referenced Oct 26, 2019
Open
Open
Open
Open
Closed
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2019
Open
This was referenced Nov 18, 2019
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 21, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 29, 2020
Open
Open
@douglaswth douglaswth mentioned this pull request May 2, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 6, 2020
Open
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
@UziTech
Merge pull request markedjs#1446 from UziTech/list-table
be213f2 
Fix tables in a list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@davisjam davisjam davisjam approved these changes

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indented tables are ignored
3 participants
@UziTech @styfle @davisjam