New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove substitutions #1532
Merged
Merged
remove substitutions #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically deployed with Now. Latest deployment for this branch: https://markedjs-git-fork-uzitech-remove-substitutions.markedjs.now.sh |
styfle
approved these changes
Aug 5, 2019
joshbruce
approved these changes
Aug 5, 2019
This was referenced Dec 20, 2019
This was referenced Apr 24, 2020
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
remove substitutions
domoscargin
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Aug 24, 2022
Previous PRs have resolved some of the issues around lists and links. The differences in the build for this PR are: eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system` I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`) See: markedjs/marked#1532 For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2 I'm uncertain as to whether this is good. I think it's fine, but there's a change some delicate spacing thing could be thrown out by it Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`). In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp! There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Aug 24, 2022
Previous PRs have resolved some of the issues around lists and links. The differences in the build for this PR are: **Heading IDs are concatenated rather than split** eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system` I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`) **Non-breaking space characters are no longer replaced with whitespace** See: markedjs/marked#1532 For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2 I'm uncertain as to whether this is good. I think it's fine, but there's a change some delicate spacing thing could be thrown out by it **Fenced code blocks are BROKEN** Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`). In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp! There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Aug 24, 2022
Previous PRs have resolved some of the issues around lists and links. The differences in the build for this PR are: **Heading IDs are concatenated rather than split** eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system` I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`) **Non-breaking space characters are no longer replaced with whitespace** See: markedjs/marked#1532 For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2 I'm uncertain as to whether this is good. I think it's fine, but there's a change some delicate spacing thing could be thrown out by it **Fenced code blocks are BROKEN** Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`). In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp! There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Aug 24, 2022
Previous PRs have resolved some of the issues around lists and links. The differences in the build for this PR are: **Heading IDs are concatenated rather than split** eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system` I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`) **Non-breaking space characters are no longer replaced with whitespace** See: markedjs/marked#1532 For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2 I'm uncertain as to whether this is good. I think it's fine, but there's a change some delicate spacing thing could be thrown out by it **Fenced code blocks are BROKEN** Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`). In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp! There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Aug 25, 2022
Previous PRs have resolved some of the issues around lists and links. The differences in the build for this PR are: **Heading IDs are concatenated rather than split** eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system` I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`) **Non-breaking space characters are no longer replaced with whitespace** See: markedjs/marked#1532 For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2 I'm uncertain as to whether this is good. I think it's fine, but there's a chance some delicate spacing thing could be thrown out by it **Fenced code blocks are BROKEN** Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`). In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp! There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Aug 31, 2022
Previous PRs have resolved some of the issues around lists and links. The differences in the build for this PR are: **Heading IDs are concatenated rather than split** eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system` I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`) **Non-breaking space characters are no longer replaced with whitespace** See: markedjs/marked#1532 For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2 I'm uncertain as to whether this is good. I think it's fine, but there's a chance some delicate spacing thing could be thrown out by it **Fenced code blocks are BROKEN** Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`). In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp! There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Sep 1, 2022
Previous PRs have resolved some of the issues around lists and links. The differences in the build for this PR are: **Heading IDs are concatenated rather than split** eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system` I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`) **Non-breaking space characters are no longer replaced with whitespace** See: markedjs/marked#1532 For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2 I'm uncertain as to whether this is good. I think it's fine, but there's a chance some delicate spacing thing could be thrown out by it **Fenced code blocks are BROKEN** Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`). In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp! There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin
added a commit
to alphagov/govuk-design-system
that referenced
this pull request
Sep 1, 2022
Previous PRs have resolved some of the issues around lists and links. The differences in the build for this PR are: **Heading IDs are concatenated rather than split** eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system` I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`) **Non-breaking space characters are no longer replaced with whitespace** See: markedjs/marked#1532 For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2 I'm uncertain as to whether this is good. I think it's fine, but there's a chance some delicate spacing thing could be thrown out by it **Fenced code blocks are BROKEN** Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`). In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp! There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: master
Description
BREAKING CHANGE:
Remove substitutions for U+00A0 and U+2424
Contributor
Committer
In most cases, this should be a different person than the contributor.