Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove substitutions #1532

Merged
merged 2 commits into from Aug 5, 2019
Merged

remove substitutions #1532

merged 2 commits into from Aug 5, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Aug 5, 2019

Marked version: master

Description

BREAKING CHANGE:
Remove substitutions for U+00A0 and U+2424

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented Aug 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://markedjs-git-fork-uzitech-remove-substitutions.markedjs.now.sh

@joshbruce joshbruce merged commit 620a27d into markedjs:master Aug 5, 2019
@UziTech UziTech deleted the remove-substitutions branch September 11, 2019 21:23
@UziTech UziTech mentioned this pull request Dec 4, 2019
12 tasks
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
domoscargin added a commit to alphagov/govuk-design-system that referenced this pull request Aug 24, 2022
Previous PRs have resolved some of the issues around lists and links.

The differences in the build for this PR are:

eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system`

I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`)

See: markedjs/marked#1532

For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2

I'm uncertain as to whether this is good. I think it's fine, but there's a change some delicate spacing thing could be thrown out by it

Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`).

In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp!

There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin added a commit to alphagov/govuk-design-system that referenced this pull request Aug 24, 2022
Previous PRs have resolved some of the issues around lists and links.

The differences in the build for this PR are:

**Heading IDs are concatenated rather than split**

eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system`

I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`)

**Non-breaking space characters are no longer replaced with whitespace**

See: markedjs/marked#1532

For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2

I'm uncertain as to whether this is good. I think it's fine, but there's a change some delicate spacing thing could be thrown out by it

**Fenced code blocks are BROKEN**

Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`).

In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp!

There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin added a commit to alphagov/govuk-design-system that referenced this pull request Aug 24, 2022
Previous PRs have resolved some of the issues around lists and links.

The differences in the build for this PR are:

**Heading IDs are concatenated rather than split**

eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system`

I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`)

**Non-breaking space characters are no longer replaced with whitespace**

See: markedjs/marked#1532

For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2

I'm uncertain as to whether this is good. I think it's fine, but there's a change some delicate spacing thing could be thrown out by it

**Fenced code blocks are BROKEN**

Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`).

In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp!

There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin added a commit to alphagov/govuk-design-system that referenced this pull request Aug 24, 2022
Previous PRs have resolved some of the issues around lists and links.

The differences in the build for this PR are:

**Heading IDs are concatenated rather than split**

eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system`

I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`)

**Non-breaking space characters are no longer replaced with whitespace**

See: markedjs/marked#1532

For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2

I'm uncertain as to whether this is good. I think it's fine, but there's a change some delicate spacing thing could be thrown out by it

**Fenced code blocks are BROKEN**

Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`).

In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp!

There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin added a commit to alphagov/govuk-design-system that referenced this pull request Aug 25, 2022
Previous PRs have resolved some of the issues around lists and links.

The differences in the build for this PR are:

**Heading IDs are concatenated rather than split**

eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system`

I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`)

**Non-breaking space characters are no longer replaced with whitespace**

See: markedjs/marked#1532

For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2

I'm uncertain as to whether this is good. I think it's fine, but there's a chance some delicate spacing thing could be thrown out by it

**Fenced code blocks are BROKEN**

Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`).

In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp!

There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin added a commit to alphagov/govuk-design-system that referenced this pull request Aug 31, 2022
Previous PRs have resolved some of the issues around lists and links.

The differences in the build for this PR are:

**Heading IDs are concatenated rather than split**

eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system`

I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`)

**Non-breaking space characters are no longer replaced with whitespace**

See: markedjs/marked#1532

For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2

I'm uncertain as to whether this is good. I think it's fine, but there's a chance some delicate spacing thing could be thrown out by it

**Fenced code blocks are BROKEN**

Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`).

In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp!

There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin added a commit to alphagov/govuk-design-system that referenced this pull request Sep 1, 2022
Previous PRs have resolved some of the issues around lists and links.

The differences in the build for this PR are:

**Heading IDs are concatenated rather than split**

eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system`

I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`)

**Non-breaking space characters are no longer replaced with whitespace**

See: markedjs/marked#1532

For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2

I'm uncertain as to whether this is good. I think it's fine, but there's a chance some delicate spacing thing could be thrown out by it

**Fenced code blocks are BROKEN**

Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`).

In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp!

There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
domoscargin added a commit to alphagov/govuk-design-system that referenced this pull request Sep 1, 2022
Previous PRs have resolved some of the issues around lists and links.

The differences in the build for this PR are:

**Heading IDs are concatenated rather than split**

eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system`

I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`)

**Non-breaking space characters are no longer replaced with whitespace**

See: markedjs/marked#1532

For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2

I'm uncertain as to whether this is good. I think it's fine, but there's a chance some delicate spacing thing could be thrown out by it

**Fenced code blocks are BROKEN**

Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`).

In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp!

There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

␤ actually becomes a newline when it shouldn't Marked removes non-breaking spaces in the original text
3 participants