Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update htmldiffer async matcher #1543

Merged
merged 5 commits into from Sep 23, 2019
Merged

Update htmldiffer async matcher #1543

merged 5 commits into from Sep 23, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Aug 27, 2019

Marked version: master

Description

update html-differ and make tests async

This will remove the security alert for diff

I had to remove testing for node v4 since html-differ uses async/await but will still catch any es6 code with eslint.

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@vercel
Copy link

vercel bot commented Aug 27, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://markedjs-git-fork-uzitech-update-htmldiffer-async-matcher.markedjs.now.sh

package.json Outdated Show resolved Hide resolved
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Apr 22, 2020
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
…-matcher

Update htmldiffer async matcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants