Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix indented tables to follow gfm spec #1748

Merged
merged 1 commit into from
Aug 13, 2020
Merged

fix indented tables to follow gfm spec #1748

merged 1 commit into from
Aug 13, 2020

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Aug 12, 2020

Marked version: 1.1.1

Markdown flavor: GitHub Flavored Markdown

Description

fixes indented table rows to act like code blocks instead of table rows.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Sorry, something went wrong.

@vercel
Copy link

vercel bot commented Aug 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/cvvaomc13
✅ Preview: https://markedjs-git-fork-uzitech-indented-tables.markedjs.vercel.app

@UziTech UziTech changed the title fix indented tables to act like gfm fix indented tables to follow gfm spec Aug 12, 2020
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the limit of 3 in the gfm spec?

Where do you see that?

@UziTech
Copy link
Member Author

UziTech commented Aug 13, 2020

If it is indented 4 spaces it is considered a code block. Which takes precedence over a table

@UziTech
Copy link
Member Author

UziTech commented Aug 13, 2020

Here is how github renders the test:

| abc | def |
            | --- | --- |
            | bar | foo |
            | baz | boo |

| abc | def |
| --- | --- |
| bar | foo |
| baz | boo |

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle merged commit 1d6afc1 into markedjs:master Aug 13, 2020
@UziTech UziTech deleted the indented-tables branch August 31, 2020 21:14
@UziTech UziTech mentioned this pull request Sep 27, 2020
12 tasks
@github-actions
Copy link

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing of whitespace prefixed tables broken after upgrade (0.7.0 => 1.1.1)
2 participants