Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartLists option does not do anything #2582

Closed
Snack-X opened this issue Sep 14, 2022 · 3 comments · Fixed by #2596
Closed

smartLists option does not do anything #2582

Snack-X opened this issue Sep 14, 2022 · 3 comments · Fixed by #2596
Labels
category: docs Documentation changes good first issue Something easy to get started with

Comments

@Snack-X
Copy link

Snack-X commented Sep 14, 2022

Marked version: since v3.0.0

Describe the bug
smartLists option exists on the documentation, but it actually does nothing.

#2112 removed usage of this option.

Expected behavior
Remove references to smartLists from code and documentation.
@UziTech
Copy link
Member

UziTech commented Sep 14, 2022

Nice catch! Since it has been gone since v3 and no one has complained I agree that we should just remove it. If you want to create a PR for that it would be very much appreciated 😁👍

@UziTech UziTech added good first issue Something easy to get started with category: docs Documentation changes labels Sep 18, 2022
@mstomar698
Copy link
Contributor

Can I take it?

@UziTech
Copy link
Member

UziTech commented Sep 29, 2022

@201b153 sounds good

@mstomar698 mstomar698 mentioned this issue Sep 30, 2022
Merged
3 tasks
UziTech pushed a commit that referenced this issue Oct 1, 2022
@mstomar698
fix: remove smartLists from docs and code (#2596)
f6ba2e3 
* Removing smarLists 

for issue #2582

* Removing smartLists

for issue #2582

* removing smarLists

for issue #2582

* removing smartLists

for issue #2582

* removing samrtLists

for issue #2582

* removing smartLists

for issue #2582

* removing smartLists

for issue #2582
github-actions bot pushed a commit that referenced this issue Oct 1, 2022
@semantic-release-bot
chore(release): 4.1.1 [skip ci]
8075e15 
## [4.1.1](v4.1.0...v4.1.1) (2022-10-01)

### Bug Fixes

* remove smartLists from docs and code ([#2596](#2596)) ([f6ba2e3](f6ba2e3)), closes [#2582](#2582) [#2582](#2582) [#2582](#2582) [#2582](#2582) [#2582](#2582) [#2582](#2582) [#2582](#2582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: docs Documentation changes good first issue Something easy to get started with
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing smartLists from docs and code
3 participants
@UziTech @Snack-X @mstomar698