Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add block param to html renderer #2768

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Apr 1, 2023

Description

Add block parameter to html tokens and a block param to html renderer to allow different renderings for inline and block level html.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Apr 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2023 1:19am

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually a breaking change? Seems like its a feature? Existing code would ignore the new arg/prop?

@UziTech
Copy link
Member Author

UziTech commented Apr 18, 2023

I wasn't sure if this should be a breaking change. It is adding a property to a token so it could break some things. I thought might as well error on the safe side.

@UziTech UziTech mentioned this pull request Apr 22, 2023
5 tasks
@UziTech UziTech changed the title BREAKING CHANGE: feat: add block param to html renderer feat: add block param to html renderer May 2, 2023
@UziTech UziTech merged commit fa21b9f into markedjs:master May 2, 2023
@UziTech UziTech deleted the html-block branch May 2, 2023 04:31
github-actions bot pushed a commit that referenced this pull request May 2, 2023
# [5.0.0](v4.3.0...v5.0.0) (2023-05-02)

### Bug Fixes

* deprecate options ([#2766](#2766)) ([62d3312](62d3312))
* update min node to v18 ([#2767](#2767)) ([c6852f5](c6852f5))

### Features

* add block param to html renderer ([#2768](#2768)) ([fa21b9f](fa21b9f))

### BREAKING CHANGES

* deprecate options
* minimum supported node version v18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML renderer should distinguish between block and inline HTML
2 participants