Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the ast stores links as a property of an array #472

Closed
notslang opened this issue Aug 12, 2014 · 2 comments
Closed

the ast stores links as a property of an array #472

notslang opened this issue Aug 12, 2014 · 2 comments

Comments

@notslang
Copy link

Arrays don't really support non-numeric keys, so using ast.links means I loose the list of links whenever I perform an operation on the array like map or concat. If you want to read more, Andrew Dupont has a short essay on why this is harmful.

So, we should change the format of the AST to something like this:

{
  'tokens': [<the array of tokens>]
  'links': {<the object that stores all the links>}
}
@Feder1co5oave
Copy link
Contributor

+1

@UziTech
Copy link
Member

UziTech commented Jul 3, 2018

fixed by #1299

@UziTech UziTech closed this as completed Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants