-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with prompt_toolkit version 2.0 #23
Comments
I saw the pt2 branch, but wasn't able to try it out, maybe because it targets a pre-release of pt2 (the req.txt seems to reference a commit that's been rebased, so it does not exist anymore?) |
Just checkout the master branch, it should be on version 2 now. |
Yes, I know, 2.0.4 is official now: but the pt2 branch does not seem to work with that neither. |
You might want to pin prompt_toolkit in requirements.txt to version 1.0.15 until you can update the library to ver 2.0. |
Pinned prompt_toolkit to version 1.0.14. Previously, it would install ver 2.0 which has breaking changes. fixes markfinkGH-23
I've been working on a fork of this stale project which runs on prompt toolkit 2: https://github.com/tmbo/questionary (does not work with prompt_toolkit 1 though, as it really is either or) |
Thanks, I will surely try it out! |
@tmbo, why have you discarded previous history? I would have expected some acknowledgement to at least markfink... Anyway, is |
@lelit my work is based on https://github.com/CITGuru/PyInquirer, so I acknowledged the work of Oyetoke Toby. But you are right, I have added Mark Fink to the Readme as well, let me know if I am missing someone. https://github.com/tmbo/questionary#contributors (is there a better place to put this?) The API is compatible for the prompt types implemented (it is compatible to PyInquierer, but I think that one is in turn API compatible). |
Great, thank you again. |
so can we close this? |
That's up to you, obviously: the existence of an PTv2-compatible alternative library does not actually change the fact that whaaaaat is not PTv2-ready. |
As prompt_toolkit 2.0 is not compatible with 1.0 (upgrade guide). whaaaaat can not be imported right now. Errors below.
Temporary fix:
The text was updated successfully, but these errors were encountered: