Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollup-express example results in error #27

Open
piyushchauhan2011 opened this issue Jun 7, 2022 · 4 comments
Open

rollup-express example results in error #27

piyushchauhan2011 opened this issue Jun 7, 2022 · 4 comments

Comments

@piyushchauhan2011
Copy link

piyushchauhan2011 commented Jun 7, 2022

After following the instructions from examples repository to try out rollup-express example, it results in js error and on the user interface, we are unable to interact with dynamic components. This happens in both dev and prod mode.

Screen Shot 2565-06-08 at 04 30 58

Screen Shot 2565-06-08 at 04 30 44


Screen Shot 2565-06-08 at 04 35 27

@piyushchauhan2011
Copy link
Author

I was wondering what can be done to try out rollup example?

@DylanPiercey
Copy link
Contributor

@piyushchauhan2011 I just took a look into this one and it appears there were changes in recent versions of @rollup/plugin-node-resolve and @rollup/plugin-commonjs. I think the fix on our end is going to require some thinking.

If you're wanting to get started with Marko I'd recommend our Vite setup for now if you're not heart set on rollup. If you did wan't to go with rollup you'll have the best luck with pinning to previous releases of these:

    "@rollup/plugin-commonjs": "21.1.0",
    "@rollup/plugin-node-resolve": "13.2.1",

@DylanPiercey
Copy link
Contributor

For future reference this is related: rollup/plugins#1195

@piyushchauhan2011
Copy link
Author

Cool, no worries. I'll continue with the Vite setup for now 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants