Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When I type Japanese text, use of a tab key for letter selection inserts 4 spaces #1250

Open
1 task done
kouichi-c-nakamura opened this issue Aug 8, 2019 · 5 comments · May be fixed by #3544
Open
1 task done

When I type Japanese text, use of a tab key for letter selection inserts 4 spaces #1250

kouichi-c-nakamura opened this issue Aug 8, 2019 · 5 comments · May be fixed by #3544
Assignees
@Jocs
Labels
❓ confirmation needed This issue needs confirmation

Comments

@kouichi-c-nakamura
Copy link

Description

  • Can you reproduce the issue?

Steps to reproduce

  1. Install Google Japanese Input to your Mac (this how I did, but I also confirmed the same behaviour with OS's default Japanese IME as well)
  2. Type Japanese text on a Mac.
  3. Choose a candidate of letters by pressing a tab key.
  4. Then, 4 spaces are inserted to the text.

Screen Shot 2019-08-08 at 7 59 08

Expected behavior:

While you're choosing a candidate of letters, tab keys should be ignored by MarkText. At this point, a Tab key is only used for going through suggested choices of letters.

The behaviour and key bindings can be dependent on IME of your choice, but I have never experienced this kind of issues in any of major editors, such as Atom or Typora.

This makes MarkText essentially unusable for Japanese users.

Actual behavior:

Tab key press is recognized by MarkText, and 4 spaces are inserted to the text.

Versions

  • Mark Text: 0.15.0
  • Operating system: macOS 10.14.6
  • Google Japanese Input 2.25.3700.1
@fxha fxha assigned Jocs Aug 9, 2019
@Jocs
Copy link
Member

Jocs commented Aug 10, 2019

@kouichi-c-nakamura Can you show me the Google Japanese Input download link, I'll download it and test this issue.

@kouichi-c-nakamura
Copy link
Author

Thanks for responding!

Web page is here: https://www.google.co.jp/ime/

This should be the download link:

https://tools.google.com/dlpage/japaneseinput/eula.html?platform=mac

  1. After installation, select Google Japanese Input as IME.
  2. Then type whatever, eg ai
  3. Google Japanese Input will show you a list of candidates. eg. Screen Shot 2019-08-10 at 8 55 38
  4. Now it's time for you to choose one by pressing a Tab key. And when you do it, Mark Text will insert 4 spaces.

@fxha fxha added the ❓ confirmation needed This issue needs confirmation label Aug 10, 2019
@shutingrz
Copy link

I am also using the Mac version of MarkText and have the same problem constantly.
Not only with Google IME, but also with macOS default IME.

This bug makes it very difficult for me to continue using MarkText.

@akiya3
Copy link

akiya3 commented Jun 27, 2022

I got same problem

MarkText ver: v0.17.1
OS: macOS 12.2.1(intel CPU)
IME: ATOK, Google

@196Ikuchil
Copy link

Hello, @Jocs and everyone.

I think the cause of this problem is this code.

marktext/src/muya/lib/contentState/tabCtrl.js

Line 301 in aed36db

ContentState.prototype.tabHandler = function (event) {

This handler shouldn't be called when the operation of 3. Choose a candidate goes on.
And I confirmed that the problem doesn't occur if this function is commented out.

Could anyone please fix this function?

@mosaicer mosaicer linked a pull request Jan 4, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jocs Jocs

Labels
❓ confirmation needed This issue needs confirmation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #1250 ignore a tab key when choosing a candidate of letters by IME mosaicer/marktext
6 participants
@shutingrz @kouichi-c-nakamura @Jocs @akiya3 @196Ikuchil @fxha