Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to disable the up-arrow search history? #692

Open
edte opened this issue Feb 21, 2024 · 11 comments
Open

Is there a way to disable the up-arrow search history? #692

edte opened this issue Feb 21, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@edte
Copy link

edte commented Feb 21, 2024

just disable this

@edte edte added the enhancement New feature or request label Feb 21, 2024
@unode
Copy link

unode commented Feb 26, 2024

Commenting out

${0}:bind main up-line-or-search $_autocomplete__key_up[@]
and
${0}:bind main down-line-or-select $_autocomplete__key_down[@]
seems to do it for me.

That said, I would also see benefit in having a way to disable or customize this behavior as it seems inconsistent with the rest.

@vedal
Copy link

vedal commented Feb 27, 2024

That said, I would also see benefit in having a way to disable or customize this behavior as it seems inconsistent with the rest.
For me, thats particularly true when up-arrowing with an empty prompt (just re-run the last command), which I do alot. It would be cool if the search history only showed up after 2 (or N) up-arrows

@duxbuse
Copy link

duxbuse commented Feb 28, 2024

Yeah I also wanted to disable it, cause it often locks up for me and I have to kill the terminal. Cant Ctrl+C out of the history menu and then its all buggered.

@ordy
Copy link

ordy commented Feb 28, 2024

Yeah I also wanted to disable it, cause it often locks up for me and I have to kill the terminal. Cant Ctrl+C out of the history menu and then its all buggered.

It used to make my terminal freeze too, until I commented the lines mentioned in this comment #645 (comment)

@edte
Copy link
Author

edte commented Feb 29, 2024

This problem has been solved. The requirement is to disable the display of fzf's history when pressing up, but after pressing tab, the arrow keys also can be able to be used in completion. Now the requirements are basically met.

my modifications:

截屏2024-02-29 11 47 56

pr:
main...edte:zsh-autocomplete:main

now:

2024-02-29.11.50.08.mov

@edte edte closed this as completed Feb 29, 2024
@unode
Copy link

unode commented Feb 29, 2024

Could you please leave this open until an actual fix is implemented?
Simply commenting out those lines isn't really a fix but more of a workaround.

@edte edte reopened this Feb 29, 2024
@abenz1267
Copy link

the readme states how to reset up/down arrow keys to zsh-default: https://github.com/marlonrichert/zsh-autocomplete?tab=readme-ov-file#reset-history-key-bindings-to-zsh-default

@MichaelFlucher
Copy link

MichaelFlucher commented Apr 2, 2024

I'm also trying to disable the history search. I just want normal scroll through the history like zsh native.
I tested both solutions, commenting out those two key binding lines, and also adding the function in .zshrc before and after sourcing zsh-autocomplete.plugin.zsh. Any suggestions to fix this?

Update: #698 (comment) putting source oh-my-zsh.sh above source zsh-autocomplete.plugin.zsh fixed it

@jul-sh
Copy link

jul-sh commented May 13, 2024

bumping this, I prefer to default behavior. it would be nice have actual config to support this.

@zt64
Copy link

zt64 commented May 17, 2024

Same issue here, tried everything suggested before and none of that works

@samscientist
Copy link

Same issue here, tried everything suggested before and none of that works

I commented on the related issue for what worked for me. Give it a try :)
#645 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants