Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

^Q unavailable in vi command mode #25

Closed
cohml opened this issue Jan 5, 2024 · 0 comments · Fixed by #26
Closed

^Q unavailable in vi command mode #25

cohml opened this issue Jan 5, 2024 · 0 comments · Fixed by #26
Labels
bug Something isn't working

Comments

@cohml
Copy link

cohml commented Jan 5, 2024

Describe the bug

The README states that this plugin binds ^Q to an action, but it doesn't do so for vi command mode.

Steps To Reproduce

Source zsh-hist and enter emacs mode.

source zsh-hist.plugin.zsh
bindkey -e

Note that the ^Q yields the desired behavior.

Now enter vi mode.

bindkey -v

After ensuring you're in insert mode (press Esc and then i to be sure), note that ^Q works.

Now press Esc to enter command mode, and note that ^Q does NOT work.

Expected behavior

push-history is not Emacs/Vi/insert/command-related, so^Q should yield the same behavior across all modes by default.

Observed behavior

^Q works only in emacs mode and vi insert mode, not vi command mode.

Click to expand

Environment:

  • OS: macOS
  • Terminal: iTerm2
  • Zsh version: 5.9
  • Repo version: * main 3efe240 Fix bugs in push-history widget
@cohml cohml added the bug Something isn't working label Jan 5, 2024
@cohml cohml changed the title ^Q unavailable in vi mode ^Q unavailable in vi command mode Jan 5, 2024
cohml pushed a commit to cohml/zsh-hist that referenced this issue Jan 5, 2024
marlonrichert pushed a commit that referenced this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant