Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of react-router-redux #1999

Closed
vascofg opened this issue Jul 5, 2018 · 9 comments
Closed

Deprecation of react-router-redux #1999

vascofg opened this issue Jul 5, 2018 · 9 comments
Assignees

Comments

@vascofg
Copy link
Contributor

vascofg commented Jul 5, 2018

React-router-redux is deprecated as can be seen here:
https://github.com/ReactTraining/react-router/tree/master/packages/react-router-redux

Any plans on finding an alternative?

@djhi
Copy link
Contributor

djhi commented Jul 5, 2018

Not yet but I guess we'll have to use https://github.com/supasate/connected-react-router

@ignlg
Copy link

ignlg commented Jul 10, 2018

I've been using https://github.com/FormidableLabs/redux-little-router with some projects, just to point at another option

@azjgard
Copy link

azjgard commented Jul 15, 2018

@ignlg Thanks a ton for passing that along!

@fongfai
Copy link

fongfai commented Oct 23, 2018

Not yet but I guess we'll have to use https://github.com/supasate/connected-react-router

Can we use react-router's {withRouter} replace react-router-redux's {routerReducer} ?

@maicWorkGithub
Copy link

Not yet but I guess we'll have to use https://github.com/supasate/connected-react-router

Can we use react-router's {withRouter} replace react-router-redux's {routerReducer} ?

https://reacttraining.com/react-router/core/guides/redux-integration/deep-integration

They say not suggested use router in redux, I'm a noob, why you choose use router in redux? what's the benefit?

@edy
Copy link
Contributor

edy commented Jan 18, 2019

What about React Navigation? They support Web and SSR too.

@fzaninotto
Copy link
Member

We've decided to replace react-router-redux with nothing - i.e. do not change route using actions from a third-party library but from the history. This is a breaking change.

@fzaninotto
Copy link
Member

After re-reading https://reacttraining.com/react-router/core/guides/redux-integration/deep-integration, the proposed solution (do not integrate react-router with redux) seems cumbersome and a very big BC break, because each action that may lead to a redirection must have the history object in its payload.

So we'll go with connected-react-router, but they haven't integrated react-redux v7 yet (see supasate/connected-react-router#287).

@fzaninotto fzaninotto self-assigned this Apr 26, 2019
@fzaninotto
Copy link
Member

Fixed by #3170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants